From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com,
Maximiliano Sandoval <m.sandoval@proxmox.com>
Subject: applied: [PATCH qemu-server v3 0/3] vm start: log qemu version when starting a VM
Date: Fri, 3 Jul 2026 15:17:56 +0200 [thread overview]
Message-ID: <178308453902.152464.1588334690373555191.b4-ty@proxmox.com> (raw)
In-Reply-To: <20260630110446.314299-1-m.sandoval@proxmox.com>
On Tue, 30 Jun 2026 13:04:36 +0200, Maximiliano Sandoval wrote:
> Differences from v2:
> - Move get_qemu_package_version and get_runnning_qemu_version to QMPHelpers.pm
>
> Differences from v1:
>
> - Fix a typo s/pgk/pkg/
> - Rename helper to get_qemu_package_version
> - Add dummy output in mockup method
>
> [...]
Applied, thanks! Changed the variable and function name in 3/3 to
clarify that it's not just the version, but the full package string
and added a comment about how the package string looks like.
[1/3] test: mock query-version qmp command
commit: 5cd70b317b74ba7406607903e8a4e587b1ee77a1
[2/3] move get_running_qemu_version to QMPHelpers
commit: 3f7e57d46c2524a718cf9bb6592ea282e0d05a33
[3/3] vm start: log qemu version when starting a VM
commit: d93e3276b2172a6c4a4ef133b17949e9eae46263
prev parent reply other threads:[~2026-07-03 13:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-30 11:04 [PATCH qemu-server v3 0/3] vm start: log qemu version when starting a VM Maximiliano Sandoval
2026-06-30 11:04 ` [PATCH qemu-server v3 1/3] test: mock query-version qmp command Maximiliano Sandoval
2026-06-30 11:04 ` [PATCH qemu-server v3 2/3] move get_running_qemu_version to QMPHelpers Maximiliano Sandoval
2026-06-30 11:04 ` [PATCH qemu-server v3 3/3] vm start: log qemu version when starting a VM Maximiliano Sandoval
2026-07-03 13:17 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178308453902.152464.1588334690373555191.b4-ty@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox