From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40])
	by lore.proxmox.com (Postfix) with ESMTPS id 42BAC1FF142
	for <inbox@lore.proxmox.com>; Fri, 03 Jul 2026 15:18:39 +0200 (CEST)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id 7FB1F2138E;
	Fri, 03 Jul 2026 15:18:38 +0200 (CEST)
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com,
	Maximiliano Sandoval <m.sandoval@proxmox.com>
Subject: applied: [PATCH qemu-server v3 0/3] vm start: log qemu version when
 starting a VM
Date: Fri,  3 Jul 2026 15:17:56 +0200
Message-ID: <178308453902.152464.1588334690373555191.b4-ty@proxmox.com>
X-Mailer: git-send-email 2.47.3
In-Reply-To: <20260630110446.314299-1-m.sandoval@proxmox.com>
References: <20260630110446.314299-1-m.sandoval@proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1783084676565
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.006 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: OZVMKGLBA5ZAUQGD4YWUQ2GZWJJGZX5E
X-Message-ID-Hash: OZVMKGLBA5ZAUQGD4YWUQ2GZWJJGZX5E
X-MailFrom: f.ebner@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

On Tue, 30 Jun 2026 13:04:36 +0200, Maximiliano Sandoval wrote:
> Differences from v2:
> - Move get_qemu_package_version and get_runnning_qemu_version to QMPHelpers.pm
> 
> Differences from v1:
> 
> - Fix a typo s/pgk/pkg/
> - Rename helper to get_qemu_package_version
> - Add dummy output in mockup method
> 
> [...]

Applied, thanks! Changed the variable and function name in 3/3 to
clarify that it's not just the version, but the full package string
and added a comment about how the package string looks like.

[1/3] test: mock query-version qmp command
      commit: 5cd70b317b74ba7406607903e8a4e587b1ee77a1
[2/3] move get_running_qemu_version to QMPHelpers
      commit: 3f7e57d46c2524a718cf9bb6592ea282e0d05a33
[3/3] vm start: log qemu version when starting a VM
      commit: d93e3276b2172a6c4a4ef133b17949e9eae46263