From: Gabriel Goller <g.goller@proxmox.com>
To: Lukas Sichert <l.sichert@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [PATCH network v2] snat: handle interface lookup failures gracefully
Date: Thu, 11 Jun 2026 17:20:18 +0200 [thread overview]
Message-ID: <178119121822.262365.9680392773267114926.b4-review@b4> (raw)
In-Reply-To: <20260601124228.77298-1-l.sichert@proxmox.com>
> 'When an IPv6 subnet is created in a Simple or EVPN zone, the setup code
> runs 'ip route get 2001:4860:4860::8888' to determine the outgoing
> interface. If the host has no IPv6 address configured, this command
> fails and aborts the loop that iterates over the plugin's subnets. This
> means that the current and subsequent bridges required for the VNETs are
> not instantiated, even though they still appear in the GUI. Starting a
> VM connected to such a VNET then fails with: 'TASK ERROR: bridge
> '<vnet>' does not exist'.
>
> Wrap the function that performs the route lookup in an eval block. If
> the lookup fails, use 'log_warn' to write the error to the system log
> and to the GUI and continue processing the remaining subnets in the
> loop.
>
> Signed-off-by: Lukas Sichert <l.sichert@proxmox.com>
LGTM
Reviewed-by: Gabriel Goller <g.goller@proxmox.com>
Tested-by: Gabriel Goller <g.goller@proxmox.com>
--
Gabriel Goller <g.goller@proxmox.com>
prev parent reply other threads:[~2026-06-11 15:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-01 12:42 [PATCH network v2] snat: handle interface lookup failures gracefully Lukas Sichert
2026-06-11 15:20 ` Gabriel Goller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178119121822.262365.9680392773267114926.b4-review@b4 \
--to=g.goller@proxmox.com \
--cc=l.sichert@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox