From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id C2FF31FF13C for ; Thu, 11 Jun 2026 17:20:29 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A2BB310AF6; Thu, 11 Jun 2026 17:20:29 +0200 (CEST) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: Re: [PATCH network v2] snat: handle interface lookup failures gracefully From: Gabriel Goller To: Lukas Sichert In-Reply-To: <20260601124228.77298-1-l.sichert@proxmox.com> References: <20260601124228.77298-1-l.sichert@proxmox.com> Date: Thu, 11 Jun 2026 17:20:18 +0200 Message-Id: <178119121822.262365.9680392773267114926.b4-review@b4> X-Mailer: b4 0.16-dev X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1781191177524 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.028 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: T2UA5DKASK7LWTC7T6KKC7S26DGPOQTH X-Message-ID-Hash: T2UA5DKASK7LWTC7T6KKC7S26DGPOQTH X-MailFrom: g.goller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: > 'When an IPv6 subnet is created in a Simple or EVPN zone, the setup code > runs 'ip route get 2001:4860:4860::8888' to determine the outgoing > interface. If the host has no IPv6 address configured, this command > fails and aborts the loop that iterates over the plugin's subnets. This > means that the current and subsequent bridges required for the VNETs are > not instantiated, even though they still appear in the GUI. Starting a > VM connected to such a VNET then fails with: 'TASK ERROR: bridge > '' does not exist'. > > Wrap the function that performs the route lookup in an eval block. If > the lookup fails, use 'log_warn' to write the error to the system log > and to the GUI and continue processing the remaining subnets in the > loop. > > Signed-off-by: Lukas Sichert LGTM Reviewed-by: Gabriel Goller Tested-by: Gabriel Goller -- Gabriel Goller