public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [PATCH widget-toolkit 1/2] location edit: make coordinates pastable
Date: Tue, 26 May 2026 16:29:50 +0200	[thread overview]
Message-ID: <177980566827.2291724.7642743588769940851.b4-ty@b4> (raw)
In-Reply-To: <20260526123716.2912640-1-d.csapak@proxmox.com>

On Tue, 26 May 2026 14:37:08 +0200, Dominik Csapak wrote:
> in either the latitude or longitude field, and add a hint as such.
> This drastically improves the usability when getting coordinates from
> online map tools.

Applied, thanks! With some small follow-ups on top:

* expanded the hint to point at how to grab coordinates (right-click
  on OpenStreetMap or Google Maps); OSM is linked directly.
* dropped the per-edit-window OSM preview link as redundant with that
  hint link - I might have comunicated that badly when suggesting that
  offlist, so that's on me. The KV grid view still renders one via
  renderLocation though.
* extended paste detection to also accept OSM permalink and marker
  URLs and Google Maps URLs (/@..., ?q=, ?ll=), plus semicolon and whitespace
  as separator for the plain "lat, lon" form. That way one can basically copy
  paste the whole URL from OSM or google most of the time and it "works".

[1/2] location edit: make coordinates pastable
      commit: 4847dbc0b822c6b40ec35c3530f617c55feb9868
[2/2] location edit: add OpenStreetMap link also in the edit window
      commit: 62345b68264d08bb3e9d573b1ed8e63fa03932a8




      parent reply	other threads:[~2026-05-26 14:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-26 12:37 [PATCH widget-toolkit 1/2] location edit: make coordinates pastable Dominik Csapak
2026-05-26 12:37 ` [PATCH widget-toolkit 2/2] location edit: add OpenStreetMap link also in the edit window Dominik Csapak
2026-05-26 14:29 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=177980566827.2291724.7642743588769940851.b4-ty@b4 \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal