From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 9E1B11FF146 for ; Tue, 26 May 2026 16:31:38 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4B1AA3E56; Tue, 26 May 2026 16:31:37 +0200 (CEST) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Dominik Csapak Subject: Re: [PATCH widget-toolkit 1/2] location edit: make coordinates pastable Date: Tue, 26 May 2026 16:29:50 +0200 Message-ID: <177980566827.2291724.7642743588769940851.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260526123716.2912640-1-d.csapak@proxmox.com> References: <20260526123716.2912640-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779805868759 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.005 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: TA6JFZWZDG7I4RPTOSYIFGJFA2G23JA4 X-Message-ID-Hash: TA6JFZWZDG7I4RPTOSYIFGJFA2G23JA4 X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 26 May 2026 14:37:08 +0200, Dominik Csapak wrote: > in either the latitude or longitude field, and add a hint as such. > This drastically improves the usability when getting coordinates from > online map tools. Applied, thanks! With some small follow-ups on top: * expanded the hint to point at how to grab coordinates (right-click on OpenStreetMap or Google Maps); OSM is linked directly. * dropped the per-edit-window OSM preview link as redundant with that hint link - I might have comunicated that badly when suggesting that offlist, so that's on me. The KV grid view still renders one via renderLocation though. * extended paste detection to also accept OSM permalink and marker URLs and Google Maps URLs (/@..., ?q=, ?ll=), plus semicolon and whitespace as separator for the plain "lat, lon" form. That way one can basically copy paste the whole URL from OSM or google most of the time and it "works". [1/2] location edit: make coordinates pastable commit: 4847dbc0b822c6b40ec35c3530f617c55feb9868 [2/2] location edit: add OpenStreetMap link also in the edit window commit: 62345b68264d08bb3e9d573b1ed8e63fa03932a8