public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH manager] ui: sdn: route map edit: make id and order required
@ 2026-05-19 14:40 Dominik Csapak
  2026-05-19 19:17 ` applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2026-05-19 14:40 UTC (permalink / raw)
  To: pve-devel

so that the UI does not let the user submit the form without them. The
API returns an error in any case, but catching this in the UI is better.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/manager6/sdn/RouteMapPanel.js | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/www/manager6/sdn/RouteMapPanel.js b/www/manager6/sdn/RouteMapPanel.js
index f7776768..ca427585 100644
--- a/www/manager6/sdn/RouteMapPanel.js
+++ b/www/manager6/sdn/RouteMapPanel.js
@@ -765,6 +765,7 @@ Ext.define('PVE.sdn.EditRouteMapEntryWindow', {
             fieldLabel: gettext('Route Map ID'),
             editable: true,
             notFoundIsValid: true,
+            allowBlank: false,
             bind: {
                 disabled: '{routeMapId}',
             },
@@ -773,6 +774,7 @@ Ext.define('PVE.sdn.EditRouteMapEntryWindow', {
             xtype: 'proxmoxintegerfield',
             name: 'order',
             fieldLabel: gettext('Order'),
+            allowBlank: false,
             bind: {
                 disabled: '{order}',
             },
-- 
2.47.3





^ permalink raw reply related	[flat|nested] 2+ messages in thread

* applied: [PATCH manager] ui: sdn: route map edit: make id and order required
  2026-05-19 14:40 [PATCH manager] ui: sdn: route map edit: make id and order required Dominik Csapak
@ 2026-05-19 19:17 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2026-05-19 19:17 UTC (permalink / raw)
  To: pve-devel, Dominik Csapak

On Tue, 19 May 2026 16:40:49 +0200, Dominik Csapak wrote:
> so that the UI does not let the user submit the form without them. The
> API returns an error in any case, but catching this in the UI is better.

Applied, thanks!

[1/1] ui: sdn: route map edit: make id and order required
      commit: c8a7a3a2d54bb21401213c93f67e1400df4107a9




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-05-19 19:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-19 14:40 [PATCH manager] ui: sdn: route map edit: make id and order required Dominik Csapak
2026-05-19 19:17 ` applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal