* [PATCH manager] sdn: fabrics: fix wireguard node "Allowed IPs" setValue
@ 2026-05-19 15:44 Gabriel Goller
2026-05-19 19:17 ` applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Gabriel Goller @ 2026-05-19 15:44 UTC (permalink / raw)
To: pve-devel; +Cc: David Riley
The setValue function on the "Allowed IPs" field on the wireguard fabric
node did not get removed correctly. When removing the content, we use
setRawValue, which only sets the displayed text and bypasses the form
change checks. Copied the fix from form/BandwidthSelector.js, looks a
bit ugly though because this is a named subclass, so callParent()
doesn't work.
Reported-by: David Riley <d.riley@proxmox.com>
Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---
www/manager6/sdn/fabrics/wireguard/NodeEdit.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/sdn/fabrics/wireguard/NodeEdit.js b/www/manager6/sdn/fabrics/wireguard/NodeEdit.js
index 9c9d2ce90bc3..ba5899cb9f1b 100644
--- a/www/manager6/sdn/fabrics/wireguard/NodeEdit.js
+++ b/www/manager6/sdn/fabrics/wireguard/NodeEdit.js
@@ -79,7 +79,7 @@ Ext.define('PVE.sdn.Fabric.WireGuard.Node.Edit', {
value = value.join(', ');
}
- this.setRawValue(value);
+ return Ext.form.field.Text.prototype.setValue.call(this, value);
},
getSubmitValue: function () {
let value = this.getValue();
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* applied: [PATCH manager] sdn: fabrics: fix wireguard node "Allowed IPs" setValue
2026-05-19 15:44 [PATCH manager] sdn: fabrics: fix wireguard node "Allowed IPs" setValue Gabriel Goller
@ 2026-05-19 19:17 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2026-05-19 19:17 UTC (permalink / raw)
To: pve-devel, Gabriel Goller; +Cc: David Riley
On Tue, 19 May 2026 17:44:32 +0200, Gabriel Goller wrote:
> The setValue function on the "Allowed IPs" field on the wireguard fabric
> node did not get removed correctly. When removing the content, we use
> setRawValue, which only sets the displayed text and bypasses the form
> change checks. Copied the fix from form/BandwidthSelector.js, looks a
> bit ugly though because this is a named subclass, so callParent()
> doesn't work.
>
> [...]
Applied, thanks!
[1/1] sdn: fabrics: fix wireguard node "Allowed IPs" setValue
commit: 3288a07a4072c4c7379775c0fdf78252e3761f75
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-19 19:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-19 15:44 [PATCH manager] sdn: fabrics: fix wireguard node "Allowed IPs" setValue Gabriel Goller
2026-05-19 19:17 ` applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox