From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [PATCH manager] fix #7599: ui: qemu: wizard: fix disk controller for windows with second cd drive
Date: Mon, 18 May 2026 12:25:40 +0200 [thread overview]
Message-ID: <177909953001.3121573.2170926101803923778.b4-ty@b4> (raw)
In-Reply-To: <20260518082419.862609-1-d.csapak@proxmox.com>
On Mon, 18 May 2026 10:24:05 +0200, Dominik Csapak wrote:
> The MultiDiskPanel recently changed to only add the first disk in
> afterrender to make sure we have a nodename to determine the
> architecture of the vm (for architecture specific defaults).
>
> In contrast the os panel in the wizard assumed the first disk was
> already added and changed the controller value based on e.g. if there is
> a second cd drive for windows virtio drivers (set it to scsi in that
> case).
>
> [...]
Applied, thanks!
[1/1] fix #7599: ui: qemu: wizard: fix disk controller for windows with second cd drive
commit: aecf27bdce984de3516691e5df7e7528b1b3c78d
prev parent reply other threads:[~2026-05-18 10:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-18 8:24 [PATCH manager] fix #7599: ui: qemu: wizard: fix disk controller for windows with second cd drive Dominik Csapak
2026-05-18 10:25 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177909953001.3121573.2170926101803923778.b4-ty@b4 \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox