From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 9CDEB1FF136 for ; Mon, 18 May 2026 12:26:27 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B831EAD12; Mon, 18 May 2026 12:26:24 +0200 (CEST) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Dominik Csapak Subject: Re: [PATCH manager] fix #7599: ui: qemu: wizard: fix disk controller for windows with second cd drive Date: Mon, 18 May 2026 12:25:40 +0200 Message-ID: <177909953001.3121573.2170926101803923778.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260518082419.862609-1-d.csapak@proxmox.com> References: <20260518082419.862609-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779099938086 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.004 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: WZ52ODF7R7ZH62P2D2I54KJXGIDNGJCW X-Message-ID-Hash: WZ52ODF7R7ZH62P2D2I54KJXGIDNGJCW X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 18 May 2026 10:24:05 +0200, Dominik Csapak wrote: > The MultiDiskPanel recently changed to only add the first disk in > afterrender to make sure we have a nodename to determine the > architecture of the vm (for architecture specific defaults). > > In contrast the os panel in the wizard assumed the first disk was > already added and changed the controller value based on e.g. if there is > a second cd drive for windows virtio drivers (set it to scsi in that > case). > > [...] Applied, thanks! [1/1] fix #7599: ui: qemu: wizard: fix disk controller for windows with second cd drive commit: aecf27bdce984de3516691e5df7e7528b1b3c78d