[PATCH pve-manager 1/1] network: drop apply flag when generating wireguard config

[PATCH pve-manager 1/1] network: drop apply flag when generating wireguard config

[Stefan Hanreich]

Otherwise, this produces an error when applying a WireGuard
configuration with newly created interfaces, because `wg syncconf`
gets called for a non-existing interface. post-up commands get
executed for existing interfaces anyway, so subsequent calls to
ifreload for existing interfaces run `wg syncconf`, making separately
applying here unnecessary.

Fixes: cdc488adf70495627b9fc1788abcc58ffcc73e60
Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---

Notes:
    Verified this by applying this patch and then changing the peers of an
    interface repeatedly and checking the interface configuration via
    `wg`.
    
    Alternatively, we could check for the existence of the interface on
    applying via something like `-e /sys/class/net/wg0`? Then only invoke
    the syncconf command only when it actually exists?

 PVE/API2/Network.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/API2/Network.pm b/PVE/API2/Network.pm
index 830daf1fa..c5863ca75 100644
--- a/PVE/API2/Network.pm
+++ b/PVE/API2/Network.pm
@@ -923,7 +923,7 @@ __PACKAGE__->register_method({
             if ($have_sdn) {
                 PVE::Network::SDN::generate_etc_network_config();
                 PVE::Network::SDN::generate_dhcp_config();
-                PVE::Network::SDN::WireGuard::generate_wireguard_config(1);
+                PVE::Network::SDN::WireGuard::generate_wireguard_config();
             }
 
             my $err = sub {
-- 
2.47.3

applied: [PATCH pve-manager 1/1] network: drop apply flag when generating wireguard config

[Thomas Lamprecht]

On Fri, 15 May 2026 16:56:19 +0200, Stefan Hanreich wrote:
> Otherwise, this produces an error when applying a WireGuard
> configuration with newly created interfaces, because `wg syncconf`
> gets called for a non-existing interface. post-up commands get
> executed for existing interfaces anyway, so subsequent calls to
> ifreload for existing interfaces run `wg syncconf`, making separately
> applying here unnecessary.
> 
> [...]

Applied, thanks!

[1/1] network: drop apply flag when generating wireguard config
      commit: 51056af5b42e46836909e4950e1a694f9441026f