* [PATCH pve-manager 1/1] sdn: evpn/bgp controller: dont send empty route-map{in,out} on create
@ 2026-05-13 15:36 Stefan Hanreich
2026-05-15 8:49 ` applied: " Fiona Ebner
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Hanreich @ 2026-05-13 15:36 UTC (permalink / raw)
To: pve-devel
Otherwise this causes an error on trying to create a EVPN / BGP
controller without any route map.
Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
www/manager6/.lint-incremental | 0
www/manager6/sdn/controllers/BgpEdit.js | 4 ++--
www/manager6/sdn/controllers/EvpnEdit.js | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
create mode 100644 www/manager6/.lint-incremental
diff --git a/www/manager6/.lint-incremental b/www/manager6/.lint-incremental
new file mode 100644
index 000000000..e69de29bb
diff --git a/www/manager6/sdn/controllers/BgpEdit.js b/www/manager6/sdn/controllers/BgpEdit.js
index 09b001f5f..8cad01ceb 100644
--- a/www/manager6/sdn/controllers/BgpEdit.js
+++ b/www/manager6/sdn/controllers/BgpEdit.js
@@ -77,14 +77,14 @@ Ext.define('PVE.sdn.controllers.BgpInputPanel', {
xtype: 'pveSDNRouteMapSelector',
name: 'route-map-in',
fieldLabel: gettext('Incoming Route Map'),
- deleteEmpty: true,
+ deleteEmpty: !me.isCreate,
skipEmptyText: true,
},
{
xtype: 'pveSDNRouteMapSelector',
name: 'route-map-out',
fieldLabel: gettext('Outgoing Route Map'),
- deleteEmpty: true,
+ deleteEmpty: !me.isCreate,
skipEmptyText: true,
},
];
diff --git a/www/manager6/sdn/controllers/EvpnEdit.js b/www/manager6/sdn/controllers/EvpnEdit.js
index 2d728f845..ae0c5a646 100644
--- a/www/manager6/sdn/controllers/EvpnEdit.js
+++ b/www/manager6/sdn/controllers/EvpnEdit.js
@@ -68,14 +68,14 @@ Ext.define('PVE.sdn.controllers.EvpnInputPanel', {
xtype: 'pveSDNRouteMapSelector',
name: 'route-map-in',
fieldLabel: gettext('Incoming Route Map'),
- deleteEmpty: true,
+ deleteEmpty: !me.isCreate,
skipEmptyText: true,
},
{
xtype: 'pveSDNRouteMapSelector',
name: 'route-map-out',
fieldLabel: gettext('Outgoing Route Map'),
- deleteEmpty: true,
+ deleteEmpty: !me.isCreate,
skipEmptyText: true,
},
{
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* applied: [PATCH pve-manager 1/1] sdn: evpn/bgp controller: dont send empty route-map{in,out} on create
2026-05-13 15:36 [PATCH pve-manager 1/1] sdn: evpn/bgp controller: dont send empty route-map{in,out} on create Stefan Hanreich
@ 2026-05-15 8:49 ` Fiona Ebner
0 siblings, 0 replies; 2+ messages in thread
From: Fiona Ebner @ 2026-05-15 8:49 UTC (permalink / raw)
To: pve-devel, Stefan Hanreich
On Wed, 13 May 2026 17:36:54 +0200, Stefan Hanreich wrote:
> Otherwise this causes an error on trying to create a EVPN / BGP
> controller without any route map.
Applied, but dropped the accidentally committed .lint-incremental
file, thanks!
[1/1] sdn: evpn/bgp controller: dont send empty route-map{in,out} on create
commit: 6ce4cb979497ab984728282c0fb280ca0833b1f9
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-15 8:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-13 15:36 [PATCH pve-manager 1/1] sdn: evpn/bgp controller: dont send empty route-map{in,out} on create Stefan Hanreich
2026-05-15 8:49 ` applied: " Fiona Ebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox