public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [PATCH common] SysFSTools: add phys/virtfns to verbose output
Date: Wed, 13 May 2026 00:50:11 +0200	[thread overview]
Message-ID: <177862586772.3364475.9347634601355149890.b4-ty@b4> (raw)
In-Reply-To: <20260430063443.89722-1-d.csapak@proxmox.com>

On Thu, 30 Apr 2026 08:32:50 +0200, Dominik Csapak wrote:
> with this we can show/detect devices that belong together, e.g. the virtfns of
> a vGPU device.
> 
> This can be helpful in a tree style display of virtfns to physfns or
> when trying to determine which virtfns belong to a specific device, etc.
> 
> 
> [...]

Applied with a few small fixups [0], thanks!

[0]:

* guard the physfn readlink, otherwise non-VF devices (i.e. most) spam
  undef warnings
* reshape virtfns as a plain hash keyed by virtfn<N>, the array wrapper
  didn't really buy us anything (readdir order isn't sorted anyway)
* document the new return fields in the lspci docstring

[1/1] SysFSTools: add phys/virtfns to verbose output
      commit: 7486fcd6c8285a815fc9bd9d457aa11ec01457da




      reply	other threads:[~2026-05-12 22:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-30  6:32 [PATCH common] SysFSTools: add phys/virtfns to verbose output Dominik Csapak
2026-05-12 22:50 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=177862586772.3364475.9347634601355149890.b4-ty@b4 \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal