From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 099DC1FF13A for ; Wed, 13 May 2026 00:50:56 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D9D8830528; Wed, 13 May 2026 00:50:53 +0200 (CEST) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Dominik Csapak Subject: Re: [PATCH common] SysFSTools: add phys/virtfns to verbose output Date: Wed, 13 May 2026 00:50:11 +0200 Message-ID: <177862586772.3364475.9347634601355149890.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260430063443.89722-1-d.csapak@proxmox.com> References: <20260430063443.89722-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778626106757 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: PFXAAQ4OMZBHKW57FUAJYCSGLV3DAKJF X-Message-ID-Hash: PFXAAQ4OMZBHKW57FUAJYCSGLV3DAKJF X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 30 Apr 2026 08:32:50 +0200, Dominik Csapak wrote: > with this we can show/detect devices that belong together, e.g. the virtfns of > a vGPU device. > > This can be helpful in a tree style display of virtfns to physfns or > when trying to determine which virtfns belong to a specific device, etc. > > > [...] Applied with a few small fixups [0], thanks! [0]: * guard the physfn readlink, otherwise non-VF devices (i.e. most) spam undef warnings * reshape virtfns as a plain hash keyed by virtfn, the array wrapper didn't really buy us anything (readdir order isn't sorted anyway) * document the new return fields in the lspci docstring [1/1] SysFSTools: add phys/virtfns to verbose output commit: 7486fcd6c8285a815fc9bd9d457aa11ec01457da