From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Kefu Chai <k.chai@proxmox.com>
Subject: applied: [PATCH manager 1/1] pve8to9: fix package lookup empty result check
Date: Tue, 12 May 2026 04:09:49 +0200 [thread overview]
Message-ID: <177855178702.1260779.13616900021089223431.b4-ty@b4> (raw)
In-Reply-To: <20260331004119.707556-2-k.chai@proxmox.com>
On Tue, 31 Mar 2026 08:41:19 +0800, Kefu Chai wrote:
> The empty result guard used two conditions that are always false for an
> array reference:
>
> if (!defined $pkgs || $pkgs == 0) {
>
> '$pkgs' from '[grep {...} @list]' is always defined, and '$pkgs == 0'
> numifies the reference (memory address), which is never zero. The
> diagnostic log_fail message was therefore never emitted when a package
> was not found in the version list.
>
> [...]
Applied, thanks!
[1/1] pve8to9: fix package lookup empty result check
commit: 0353b1e390d89acb1792a136df4c9c73441e0368
next prev parent reply other threads:[~2026-05-12 2:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 0:41 [PATCH manager 0/1] pve8to9: fix package lookup empty result check Kefu Chai
2026-03-31 0:41 ` [PATCH manager 1/1] " Kefu Chai
2026-05-12 2:09 ` Thomas Lamprecht [this message]
2026-05-08 1:05 ` [PATCH manager] " Kefu Chai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177855178702.1260779.13616900021089223431.b4-ty@b4 \
--to=t.lamprecht@proxmox.com \
--cc=k.chai@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox