From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id F30AC1FF146
	for <inbox@lore.proxmox.com>; Tue, 12 May 2026 04:10:03 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 00BAD26F91;
	Tue, 12 May 2026 04:10:01 +0200 (CEST)
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com,
	Kefu Chai <k.chai@proxmox.com>
Subject: applied: [PATCH manager 1/1] pve8to9: fix package lookup empty result
 check
Date: Tue, 12 May 2026 04:09:49 +0200
Message-ID: <177855178702.1260779.13616900021089223431.b4-ty@b4>
X-Mailer: git-send-email 2.47.3
In-Reply-To: <20260331004119.707556-2-k.chai@proxmox.com>
References: <20260331004119.707556-2-k.chai@proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1778551685473
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.003 Adjusted score from AWL reputation of From:
 address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: 225HHHOIYK6CPXGK6KRNSCNEIKP7VX5Y
X-Message-ID-Hash: 225HHHOIYK6CPXGK6KRNSCNEIKP7VX5Y
X-MailFrom: t.lamprecht@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

On Tue, 31 Mar 2026 08:41:19 +0800, Kefu Chai wrote:
> The empty result guard used two conditions that are always false for an
> array reference:
> 
>   if (!defined $pkgs || $pkgs == 0) {
> 
> '$pkgs' from '[grep {...} @list]' is always defined, and '$pkgs == 0'
> numifies the reference (memory address), which is never zero. The
> diagnostic log_fail message was therefore never emitted when a package
> was not found in the version list.
> 
> [...]

Applied, thanks!

[1/1] pve8to9: fix package lookup empty result check
      commit: 0353b1e390d89acb1792a136df4c9c73441e0368