public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH pve-manager] fix #6348: ui: bulk action: use tag style full
@ 2026-05-13 11:25 Erik Fastermann
  2026-05-15  7:00 ` Dominik Csapak
  0 siblings, 1 reply; 2+ messages in thread
From: Erik Fastermann @ 2026-05-13 11:25 UTC (permalink / raw)
  To: pve-devel; +Cc: Erik Fastermann

Use the tag style full in the bulk action table to bring this component
more in line with the rest of the GUI.

Not using the tree config option, since the other components also have
the tag style hardcoded to full. This is the simplest change for now
and should solve the user's initial problem.

Signed-off-by: Erik Fastermann <e.fastermann@proxmox.com>
---
 www/manager6/form/VMSelector.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/form/VMSelector.js b/www/manager6/form/VMSelector.js
index 57aa73a7..a7133522 100644
--- a/www/manager6/form/VMSelector.js
+++ b/www/manager6/form/VMSelector.js
@@ -18,7 +18,7 @@ Ext.define('PVE.form.VMSelector', {
         sorters: 'vmid',
     },
 
-    userCls: 'proxmox-tags-circle',
+    userCls: 'proxmox-tags-full',
 
     columnsDeclaration: [
         {
-- 
2.47.3




^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH pve-manager] fix #6348: ui: bulk action: use tag style full
  2026-05-13 11:25 [PATCH pve-manager] fix #6348: ui: bulk action: use tag style full Erik Fastermann
@ 2026-05-15  7:00 ` Dominik Csapak
  0 siblings, 0 replies; 2+ messages in thread
From: Dominik Csapak @ 2026-05-15  7:00 UTC (permalink / raw)
  To: Erik Fastermann, pve-devel

Hi,

IMO this does not really fix the bug since it was opened for applying
the tree style to the remaining view.

The problem here is that we don't have much space, and on systems with
many tags it is less clear which ones are there, since they simply
get cut off.


This was the reason why mulitple styles were implemented in the first
place; if someone has just a few tags, the full style can be fine,
but with e.g. 5+ tags per vm this gets overwhelming fast and a
simple 'color' view can be better.

So instead of using always full here, i'd still probably opt for
re-using the tree style here. If there are more places we apply
this style to, we could even rename it to simply "tag style"
(at least in the ui)


On 5/13/26 1:25 PM, Erik Fastermann wrote:
> Use the tag style full in the bulk action table to bring this component
> more in line with the rest of the GUI.
> 
> Not using the tree config option, since the other components also have
> the tag style hardcoded to full. This is the simplest change for now
> and should solve the user's initial problem.
> 
> Signed-off-by: Erik Fastermann <e.fastermann@proxmox.com>
> ---
>   www/manager6/form/VMSelector.js | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/www/manager6/form/VMSelector.js b/www/manager6/form/VMSelector.js
> index 57aa73a7..a7133522 100644
> --- a/www/manager6/form/VMSelector.js
> +++ b/www/manager6/form/VMSelector.js
> @@ -18,7 +18,7 @@ Ext.define('PVE.form.VMSelector', {
>           sorters: 'vmid',
>       },
>   
> -    userCls: 'proxmox-tags-circle',
> +    userCls: 'proxmox-tags-full',
>   
>       columnsDeclaration: [
>           {





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-05-15  7:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-13 11:25 [PATCH pve-manager] fix #6348: ui: bulk action: use tag style full Erik Fastermann
2026-05-15  7:00 ` Dominik Csapak

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal