[pmg-devel] [PATCH pmg-gui] dkim selector view: fix viewing larger DKIM TXT records

[pmg-devel] [PATCH pmg-gui] dkim selector view: fix viewing larger DKIM TXT records

[Dominik Csapak]

It seems the 'grow' feature of the textarea only works properly on user
input, not when automatically filling it with data. So instead of trying
to do that, which only ever clipped the record if it was too large,
simply use a fixed size that is enough for 4096 bit sized keys and show
a scrollbar for larger ones.

With having a fixed height, and horizontal resizing a textarea also not
working properly in an edit window, prevent the whole window from
resizing.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 js/DKIMSettings.js | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/js/DKIMSettings.js b/js/DKIMSettings.js
index e5f6c76..323f0b6 100644
--- a/js/DKIMSettings.js
+++ b/js/DKIMSettings.js
@@ -53,7 +53,7 @@ Ext.define('PMG.SelectorViewer', {
     title: gettext('Selector'),
 
     width: 800,
-    resizable: true,
+    resizable: false,
 
     items: [
 	{
@@ -69,9 +69,7 @@ Ext.define('PMG.SelectorViewer', {
 	{
 	    xtype: 'textarea',
 	    editable: false,
-	    grow: true,
-	    growMin: 150,
-	    growMax: 400,
+	    height: 220,
 	    fieldLabel: gettext('DNS TXT Record'),
 	    name: 'record',
 	    value: 'Could not read private key!',
-- 
2.39.5



_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel

[pmg-devel] applied: [PATCH pmg-gui] dkim selector view: fix viewing larger DKIM TXT records

[Thomas Lamprecht]

Am 26.02.25 um 17:07 schrieb Dominik Csapak:
> It seems the 'grow' feature of the textarea only works properly on user
> input, not when automatically filling it with data. So instead of trying
> to do that, which only ever clipped the record if it was too large,
> simply use a fixed size that is enough for 4096 bit sized keys and show
> a scrollbar for larger ones.
> 
> With having a fixed height, and horizontal resizing a textarea also not
> working properly in an edit window, prevent the whole window from
> resizing.
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  js/DKIMSettings.js | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
>

applied, thanks!


_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel