From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pmg-devel@lists.proxmox.com, Dominik Csapak <d.csapak@proxmox.com>
Subject: applied: [PATCH pmg-api 1/3] pmgpolicy: fix failing run_command in children
Date: Wed, 10 Jun 2026 14:28:45 +0200 [thread overview]
Message-ID: <178109384408.989910.13793521539252332640.b4-ty@proxmox.com> (raw)
In-Reply-To: <20260610113634.2172613-1-d.csapak@proxmox.com>
Thanks for the analysis and digging into this so quickly!
I gave it a spin on a reproducer of the issue (first only with your 1/3
and then additionally with your 2/3 applied) and it fixes the issue.
decided to apply both patches after looking through the commit-history of
pmgpolicy, and checking Net::Servers changes from a git-repository on
github [0] - it seems that the handling of SIGPIPE and SIGCHLD was added
at some point 2005 286cd15 ("fix signal handling"), while our
copy of run_child might have been copied off before that.
In any case it does not look like it was a deliberate decision to
keep the SIGCHLD handler from the parent.
I dropped the 3/3 that got sent by mistake.
[0] https://github.com/rhandom/perl-net-server.git
On Wed, 10 Jun 2026 13:35:44 +0200, Dominik Csapak wrote:
> Net::Server::PreForkSimple installs a handler for that in the parent
> which reaps all children automatically with `waitpid(-1, ...)` and this
> gets copied over on fork. Normally, the default `run_child` method sets
> this back to the default, but in pmgpolicy that is overwritten and not
> all signal handlers are set correctly.
>
> This handler with its waitpid will be called before the one in
> `run_command` which results in an error there.
>
> [...]
Applied, thanks!
[1/3] pmgpolicy: fix failing run_command in children
commit: 66d7976b9c73aacd94d0f66d5a28302a985cc5e5
[2/3] pmgpolicy: mimic Net::Server::PreForkSimple's signal handlers in child
commit: c3b01e45d841e66779698fb03866fe5d397b56f3
prev parent reply other threads:[~2026-06-10 12:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 11:35 [PATCH pmg-api 1/3] pmgpolicy: fix failing run_command in children Dominik Csapak
2026-06-10 11:35 ` [RFC PATCH pmg-api 2/3] pmgpolicy: mimic Net::Server::PreForkSimple's signal handlers in child Dominik Csapak
2026-06-10 11:35 ` [PATCH pmg-api 3/3] Revert "d/control: depend on proxmox-enterprise-support-keyring" Dominik Csapak
2026-06-10 11:37 ` Dominik Csapak
2026-06-10 12:28 ` Stoiko Ivanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178109384408.989910.13793521539252332640.b4-ty@proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox