From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 28F201FF13A for ; Wed, 10 Jun 2026 14:29:10 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B1056C678; Wed, 10 Jun 2026 14:29:09 +0200 (CEST) From: Stoiko Ivanov To: pmg-devel@lists.proxmox.com, Dominik Csapak Subject: applied: [PATCH pmg-api 1/3] pmgpolicy: fix failing run_command in children Date: Wed, 10 Jun 2026 14:28:45 +0200 Message-ID: <178109384408.989910.13793521539252332640.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260610113634.2172613-1-d.csapak@proxmox.com> References: <20260610113634.2172613-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1781094498256 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.084 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 6LDXPAARW25NW2YEKURJQILMVP7GUEJU X-Message-ID-Hash: 6LDXPAARW25NW2YEKURJQILMVP7GUEJU X-MailFrom: s.ivanov@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Thanks for the analysis and digging into this so quickly! I gave it a spin on a reproducer of the issue (first only with your 1/3 and then additionally with your 2/3 applied) and it fixes the issue. decided to apply both patches after looking through the commit-history of pmgpolicy, and checking Net::Servers changes from a git-repository on github [0] - it seems that the handling of SIGPIPE and SIGCHLD was added at some point 2005 286cd15 ("fix signal handling"), while our copy of run_child might have been copied off before that. In any case it does not look like it was a deliberate decision to keep the SIGCHLD handler from the parent. I dropped the 3/3 that got sent by mistake. [0] https://github.com/rhandom/perl-net-server.git On Wed, 10 Jun 2026 13:35:44 +0200, Dominik Csapak wrote: > Net::Server::PreForkSimple installs a handler for that in the parent > which reaps all children automatically with `waitpid(-1, ...)` and this > gets copied over on fork. Normally, the default `run_child` method sets > this back to the default, but in pmgpolicy that is overwritten and not > all signal handlers are set correctly. > > This handler with its waitpid will be called before the one in > `run_command` which results in an error there. > > [...] Applied, thanks! [1/3] pmgpolicy: fix failing run_command in children commit: 66d7976b9c73aacd94d0f66d5a28302a985cc5e5 [2/3] pmgpolicy: mimic Net::Server::PreForkSimple's signal handlers in child commit: c3b01e45d841e66779698fb03866fe5d397b56f3