public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pmg-devel@lists.proxmox.com, Dominik Csapak <d.csapak@proxmox.com>
Subject: applied: [PATCH pmg-api] fix missing postfix welcomelist update
Date: Wed, 10 Jun 2026 11:00:24 +0200	[thread overview]
Message-ID: <178108168878.943704.15552002857960334107.b4-ty@proxmox.com> (raw)
In-Reply-To: <20260610074043.501612-1-d.csapak@proxmox.com>

Thanks for catching this!

reproduced the issue by - removing all of the smtp-welcomelist files (and
their postmap output - senderaccess, rcptaccess, clientaccess,
postscreen_access) and changing something in master.cf (adding -v to one
of the processes) and rebooting.

As talked off-list - the side-effects `||=` have caused issues before:
991d8f1c ("pmg-daily: avoid short-circuting update of local channels")
(despite fixing this back then I did not remember it now..)
I'll send a follow-up on-list that replaces ||= with your version -
it reads nicer too.


On Wed, 10 Jun 2026 09:39:16 +0200, Dominik Csapak wrote:
> Similar fix as
>  17f17bc (config: do not shortcircuit smtp-welcomelist generation)
> 
> If `$changes` is already true, 'rewrite_postfix_welcomelist' will never
> called.
> 
> This prevented those file generation on first boot after a fresh
> install.
> 
> [...]

Applied, thanks!

[1/1] fix missing postfix welcomelist update
      commit: 2ab0c72b8f536cb2a80a3b0561b1705ef67bc052





      reply	other threads:[~2026-06-10  9:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-10  7:39 [PATCH pmg-api] fix missing postfix welcomelist update Dominik Csapak
2026-06-10  9:00 ` Stoiko Ivanov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178108168878.943704.15552002857960334107.b4-ty@proxmox.com \
    --to=s.ivanov@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal