From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id BEE991FF13A for ; Wed, 10 Jun 2026 11:00:40 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6B8EF723F; Wed, 10 Jun 2026 11:00:40 +0200 (CEST) From: Stoiko Ivanov To: pmg-devel@lists.proxmox.com, Dominik Csapak Subject: applied: [PATCH pmg-api] fix missing postfix welcomelist update Date: Wed, 10 Jun 2026 11:00:24 +0200 Message-ID: <178108168878.943704.15552002857960334107.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260610074043.501612-1-d.csapak@proxmox.com> References: <20260610074043.501612-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1781081989066 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.084 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [master.cf] Message-ID-Hash: YI5EF6Y2YKHHENJOO52TB6HUVUOC74PB X-Message-ID-Hash: YI5EF6Y2YKHHENJOO52TB6HUVUOC74PB X-MailFrom: s.ivanov@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Thanks for catching this! reproduced the issue by - removing all of the smtp-welcomelist files (and their postmap output - senderaccess, rcptaccess, clientaccess, postscreen_access) and changing something in master.cf (adding -v to one of the processes) and rebooting. As talked off-list - the side-effects `||=` have caused issues before: 991d8f1c ("pmg-daily: avoid short-circuting update of local channels") (despite fixing this back then I did not remember it now..) I'll send a follow-up on-list that replaces ||= with your version - it reads nicer too. On Wed, 10 Jun 2026 09:39:16 +0200, Dominik Csapak wrote: > Similar fix as > 17f17bc (config: do not shortcircuit smtp-welcomelist generation) > > If `$changes` is already true, 'rewrite_postfix_welcomelist' will never > called. > > This prevented those file generation on first boot after a fresh > install. > > [...] Applied, thanks! [1/1] fix missing postfix welcomelist update commit: 2ab0c72b8f536cb2a80a3b0561b1705ef67bc052