Re: [PATCH pmg-api/pmg-docs/pmg-gui 0/5] add optional consent-banner to be shown before login

[Dominik Csapak <d.csapak@proxmox.com>]

had a look over the code and tested a bit.

a few high level points:

* not sure if we would benefit from refactoring the 'consent-text'
   schema/format into pve-common (this was recently also done for the
   'location', but since we only have it in two places currently
   i'd tend not to, so this looks currently fine to me

* the consent text will not be shown in the quarantine view.
   my guess is that users who need the consent text also need it in the
   quarantine (maybe even before automatically logging in?)
   should we add a separate consent text? we could always add this later
   too though. If we add this, we'd also have to add it in the mobile
   quarantine of course.


Aside from these, consider the patches:

Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Dominik Csapak <d.csapak@proxmox.com>


On 6/8/26 8:57 AM, Stoiko Ivanov wrote:
> The idea is taken, and the code mostly copied from PVE, where this was
> added to address:
> https://bugzilla.proxmox.com/show_bug.cgi?id=5463
> 
> pmg-docs:
> 
> Stoiko Ivanov (1):
>    pmgconfig: add short documentation of the consent banner
> 
>   pmgconfig.adoc | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> 
> pmg-api:
> 
> Stoiko Ivanov (2):
>    config: add consent-text key
>    pmgproxy: pass consent-text as template variable to index
> 
>   src/PMG/Config.pm           | 7 +++++++
>   src/PMG/Service/pmgproxy.pm | 2 ++
>   2 files changed, 9 insertions(+)
> 
> 
> pmg-gui:
> 
> Stoiko Ivanov (2):
>    login: show optional consent-banner before login
>    system options: add online help link for consent banner
> 
>   js/LoginView.js     | 11 +++++++++++
>   js/SystemOptions.js |  8 ++++++++
>   pmg-index.html.tt   |  1 +
>   3 files changed, 20 insertions(+)
> 
> 
> Summary over all repositories:
>    6 files changed, 36 insertions(+), 0 deletions(-)
>