From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 9E4F91FF13B for ; Mon, 08 Jun 2026 09:19:45 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 41CCC143E4; Mon, 8 Jun 2026 09:19:45 +0200 (CEST) Message-ID: <080831a6-4b04-4030-b174-0fac7710f877@proxmox.com> Date: Mon, 8 Jun 2026 09:19:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH pmg-api/pmg-docs/pmg-gui 0/5] add optional consent-banner to be shown before login To: Stoiko Ivanov , pmg-devel@lists.proxmox.com References: <20260608065653.624545-1-s.ivanov@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20260608065653.624545-1-s.ivanov@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1780903136877 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.049 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com,pmgproxy.pm,config.pm,html.tt] Message-ID-Hash: OS4OKDWUW2WAQVN4AT2KOUWZNSV5ATWE X-Message-ID-Hash: OS4OKDWUW2WAQVN4AT2KOUWZNSV5ATWE X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: had a look over the code and tested a bit. a few high level points: * not sure if we would benefit from refactoring the 'consent-text' schema/format into pve-common (this was recently also done for the 'location', but since we only have it in two places currently i'd tend not to, so this looks currently fine to me * the consent text will not be shown in the quarantine view. my guess is that users who need the consent text also need it in the quarantine (maybe even before automatically logging in?) should we add a separate consent text? we could always add this later too though. If we add this, we'd also have to add it in the mobile quarantine of course. Aside from these, consider the patches: Reviewed-by: Dominik Csapak Tested-by: Dominik Csapak On 6/8/26 8:57 AM, Stoiko Ivanov wrote: > The idea is taken, and the code mostly copied from PVE, where this was > added to address: > https://bugzilla.proxmox.com/show_bug.cgi?id=5463 > > pmg-docs: > > Stoiko Ivanov (1): > pmgconfig: add short documentation of the consent banner > > pmgconfig.adoc | 7 +++++++ > 1 file changed, 7 insertions(+) > > > pmg-api: > > Stoiko Ivanov (2): > config: add consent-text key > pmgproxy: pass consent-text as template variable to index > > src/PMG/Config.pm | 7 +++++++ > src/PMG/Service/pmgproxy.pm | 2 ++ > 2 files changed, 9 insertions(+) > > > pmg-gui: > > Stoiko Ivanov (2): > login: show optional consent-banner before login > system options: add online help link for consent banner > > js/LoginView.js | 11 +++++++++++ > js/SystemOptions.js | 8 ++++++++ > pmg-index.html.tt | 1 + > 3 files changed, 20 insertions(+) > > > Summary over all repositories: > 6 files changed, 36 insertions(+), 0 deletions(-) >