Re: [RFC datacenter-manager/proxmox v2 0/4] log: allow finegrained control logging levels

["Thomas Ellmenreich" <t.ellmenreich@proxmox.com>]

On Fri Oct 2, 2026 at 11:44 AM CEST, Lukas Wagner wrote:
> On Fri Oct 2, 2026 at 11:34 AM CEST, Thomas Ellmenreich wrote:
>> Thank you very much for your review. I will address the changes in the
>> next version. I have one question below:
>>
>> On Fri Oct 2, 2026 at 10:10 AM CEST, Lukas Wagner wrote:
>>
>> [snip]
>>
>>>> - Initially, I found case 3. of the different logging cases quite confusing and
>>>>   would have thought that our 'default_log_level' should apply as default in
>>>>   that case. Unfortunately, when setting 'default_log_level' and then applying
>>>>   the EnvFilter string, tracing applies the modules as expected, but then also
>>>>   overrides the default as '', which means off.
>>>
>>> Indeed a bit confusing, but since this is (mostly) a
>>> developer/supporter feature, as long at this behavior is documented
>>> somewhere, it should be manageable.
>>
>> Since you mentioned it, should I add some documentation somewhere
>> explaining how to use these env filters? If so, where would be the best
>> place for it?
>
> Since as I mentioned this is (mostly) a developer-feature, I think adding
> a small section about it in the 'dev-docs' (this is a folder in the PDM
> repo) would be a good start.
>
> It of course still could also make sense to mention in the user-facing
> product documentation, but as we have briefly discussed off-list, module
> paths are inherently unstable, so it's somewhat pointless to provide
> examples there. Familiarity with the code structure is required to
> properly use this feature.

Yes, I totally understand. I was also thinking of adding it to the developer
focus documentation for the reasons you mentioned.

> So for now, I'd just add it as developer documentation.
>
> I've noticed that PDM and PBS use different conventions for the
> environment variable, in PDM we use PROXMOX_DEBUG, while in PBS we use
> PBS_LOG -- maybe that's also something where we should find a common
> style to use. Just thinking out aloud here, no need to touch this as
> part of this series, of course.

I was actually wondering about this when creating the series. In my mind, all
log level variables should end with '_LOG', but we can't really replace
'PROXMOX_DEBUG' since it is already in use. Could we also support a 'PDM_LOG'
variable alongside it, and then first deprecate and later remove the old one?
(Not for this series, but just as a thought)

>>
>> [snip]