Re: [PATCH proxmox v2 2/4] fix #6081: log: replace simple level filter with env filter

["Lukas Wagner" <l.wagner@proxmox.com>]

On Wed Sep 23, 2026 at 1:58 PM CEST, Thomas Ellmenreich wrote:
> Instead of parsing the contents of the environment variable passed to the
> Logger as a simple LevelFilter, parse them as an EnvFilter [0]. This is
> backwards compatible, as a simple LevelFilter [1] string is parsable as
> an EnvFilter.
>

Looks good to me, one small note inline.

> +
> +    /// If present, tries to parse the `env_filter_str` as a [`EnvFilter`],
> +    /// otherwiese falls back to the provided default log level.
> +    ///
> +    /// The provided default log level is a application default defined by us.
> +    /// The user can define their own default as part of the [`EnvFilter`]
> +    ///
> +    /// * `env_filter_str` - The log settings that would usually be written into
> +    ///                      a environment variable and then extracted by [`get_env_variable`]
> +    /// * `default_log_level` - Default log level used by the [`Logger`] in
> +    ///                         case the log settings are empty.

Thanks for the extensive documentation!

This produceds 2 clippy warnings (warning: doc list item overindented),
please fix these for the next iteration of this series.

> +    fn apply_default_log_level(
> +        env_filter_str: Option<String>,
> +        default_log_level: LevelFilter,
> +    ) -> EnvFilter {
> +        if let Some(env_filter_str) = env_filter_str {
> +            match EnvFilter::try_new(env_filter_str) {
> +                Ok(filter) => return filter,
> +                Err(e) => eprintln!("unable to parse the log env variable: {e:#}"),
> +            }
> +        }
> +        EnvFilter::default().add_directive(default_log_level.into())
> +    }
>  }
> +
> diff --git a/proxmox-log/src/lib.rs b/proxmox-log/src/lib.rs
> index 2d321f20..32c10e27 100644
> --- a/proxmox-log/src/lib.rs
> +++ b/proxmox-log/src/lib.rs
> @@ -1,7 +1,6 @@
>  #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
>  #![deny(unsafe_op_in_unsafe_fn)]
>  
> -use std::env;
>  use std::future::Future;
>  use std::sync::{Arc, Mutex};
>  
> @@ -147,21 +146,6 @@ where
>          .with_writer(std::io::stderr)
>  }
>  
> -fn get_env_variable(env_var: &str, default_log_level: LevelFilter) -> LevelFilter {
> -    let mut log_level = default_log_level;
> -    if let Ok(v) = env::var(env_var) {
> -        match v.parse::<LevelFilter>() {
> -            Ok(l) => {
> -                log_level = l;
> -            }
> -            Err(e) => {
> -                eprintln!("env variable {env_var} found, but parsing failed: {e:?}");
> -            }
> -        }
> -    }
> -    log_level
> -}
> -
>  /// Initialize tracing logger that prints to journald or stderr depending on if we are in a pbs
>  /// task.
>  ///