From: "Thomas Ellmenreich" <t.ellmenreich@proxmox.com>
To: "Lukas Wagner" <l.wagner@proxmox.com>, <pdm-devel@lists.proxmox.com>
Subject: Re: [RFC datacenter-manager/proxmox v2 0/4] log: allow finegrained control logging levels
Date: Fri, 02 Oct 2026 11:34:20 +0200 [thread overview]
Message-ID: <DLU8ZXL98GE5.EQBRXLIJEBD9@proxmox.com> (raw)
In-Reply-To: <DLU77E1N0NKI.2ELPWL0RMIP8Z@proxmox.com>
Thank you very much for your review. I will address the changes in the
next version. I have one question below:
On Fri Oct 2, 2026 at 10:10 AM CEST, Lukas Wagner wrote:
[snip]
>> - Initially, I found case 3. of the different logging cases quite confusing and
>> would have thought that our 'default_log_level' should apply as default in
>> that case. Unfortunately, when setting 'default_log_level' and then applying
>> the EnvFilter string, tracing applies the modules as expected, but then also
>> overrides the default as '', which means off.
>
> Indeed a bit confusing, but since this is (mostly) a
> developer/supporter feature, as long at this behavior is documented
> somewhere, it should be manageable.
Since you mentioned it, should I add some documentation somewhere
explaining how to use these env filters? If so, where would be the best
place for it?
[snip]
next prev parent reply other threads:[~2026-10-02 9:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 11:57 [RFC datacenter-manager/proxmox v2 0/4] log: allow finegrained control logging levels Thomas Ellmenreich
2026-09-23 11:57 ` [PATCH proxmox v2 1/4] log: replace per layer filtering by one global filter Thomas Ellmenreich
2026-10-02 8:10 ` Lukas Wagner
2026-09-23 11:58 ` [PATCH proxmox v2 2/4] fix #6081: log: replace simple level filter with env filter Thomas Ellmenreich
2026-10-02 8:10 ` Lukas Wagner
2026-09-23 11:58 ` [PATCH proxmox v2 3/4] log: add tests to the logger Thomas Ellmenreich
2026-10-02 8:10 ` Lukas Wagner
2026-09-23 11:58 ` [PATCH datacenter-manager v2 4/4] api: set REST server debug level based on actual log level Thomas Ellmenreich
2026-10-02 8:10 ` [RFC datacenter-manager/proxmox v2 0/4] log: allow finegrained control logging levels Lukas Wagner
2026-10-02 9:34 ` Thomas Ellmenreich [this message]
2026-10-02 9:44 ` Lukas Wagner
2026-10-02 10:00 ` Thomas Ellmenreich
2026-10-02 10:59 ` Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DLU8ZXL98GE5.EQBRXLIJEBD9@proxmox.com \
--to=t.ellmenreich@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox