From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Lukas Wagner" <l.wagner@proxmox.com>, <pdm-devel@lists.proxmox.com>
Subject: Re: [PATCH proxmox-backup 04/11] config/server/api: add certificate renewal logic including notifications
Date: Wed, 29 Jul 2026 12:13:32 +0200 [thread overview]
Message-ID: <DKAZ4JEWITSA.2NSSUZ42SRDQQ@proxmox.com> (raw)
In-Reply-To: <DKAZ0YLQI8TG.3GQ0Q2ADUOUWK@proxmox.com>
On Wed Jul 29, 2026 at 12:08 PM CEST, Lukas Wagner wrote:
> On Wed Jul 29, 2026 at 11:53 AM CEST, Shannon Sterz wrote:
-->8 snip 8<--
>>>> +Proxmox Backup Server will refresh its TLS certificate within the next 30 days.
>>>
>>> I wonder, would it be possible to include a concrete date here? If I
>>> understood it correctly, the first time the user receives this
>>> notification, the renewal would be first attempted in 15 days at the
>>> earliest, so maybe this should be mentioned.
>>
>> i can add a line that the earliest a certificate will updated is in X
>> days.
>>
>> adding a date is imo a bit trickier due to localization. as far as i can
>> tell, handlebars [1] currently has no date formatting helpers. so either
>> we implement our own, which seems orthogonal to this series and probably
>> not worth it if we do decide to switch templating engines in the near
>> future. or we don't care about localization and simply decide on one
>> format (e.g. YYYY-MM-DD).
>>
>> what do you think?
>>
>> [1]: https://github.com/sunng87/handlebars-rust/issues/614
>
> Notifications are not localized at all right now, so I think if we just
> use ISO 8601 (so YYYY-MM-DD), it should be clear enough for most users.
ack, i mostly thought of users doing localization themselves by
overriding the templates, but will do that then.
next prev parent reply other threads:[~2026-07-29 10:13 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-18 11:54 [PATCH datacenter-manager/proxmox{,-backup} 00/11] TLS Certificate Rotation Shannon Sterz
2026-06-18 11:54 ` [PATCH proxmox 01/11] acme-api: make self-signed certificate expiry configurable Shannon Sterz
2026-07-10 11:15 ` Lukas Wagner
2026-07-29 9:53 ` Shannon Sterz
2026-06-18 11:54 ` [PATCH proxmox-backup 02/11] config: use proxmox_acme_api for generating self-signed certificates Shannon Sterz
2026-06-18 11:54 ` [PATCH proxmox-backup 03/11] config: adapt to api change in proxmox_acme_api, add expiry paramter Shannon Sterz
2026-06-18 11:54 ` [PATCH proxmox-backup 04/11] config/server/api: add certificate renewal logic including notifications Shannon Sterz
2026-07-10 11:17 ` Lukas Wagner
2026-07-29 9:53 ` Shannon Sterz
2026-07-29 10:08 ` Lukas Wagner
2026-07-29 10:13 ` Shannon Sterz [this message]
2026-07-29 10:29 ` Lukas Wagner
2026-06-18 11:54 ` [PATCH proxmox-backup 05/11] daily-update/docs: warn on excessive self-signed certificate lifetime Shannon Sterz
2026-07-10 11:17 ` Lukas Wagner
2026-07-29 9:53 ` Shannon Sterz
2026-06-18 11:54 ` [PATCH proxmox-backup 06/11] backup-manager cli: `cert update` can create auth and csrf key Shannon Sterz
2026-06-18 11:54 ` [PATCH datacenter-manager 07/11] certs: adapt to api change in proxmox_acme_api, add expiry paramter Shannon Sterz
2026-06-18 11:54 ` [PATCH datacenter-manager 08/11] api/auth/bin: add certificate renewal logic Shannon Sterz
2026-07-10 11:17 ` Lukas Wagner
2026-07-29 9:53 ` Shannon Sterz
2026-06-18 11:54 ` [PATCH datacenter-manager 09/11] cli: expose certificate management endpoints via the cli Shannon Sterz
2026-06-18 11:54 ` [PATCH datacenter-manager 10/11] daily-update/docs: warn on excessive tls certificate validity periods Shannon Sterz
2026-06-18 11:54 ` [PATCH datacenter-manager 11/11] docs/certificates: use correct certificate file name Shannon Sterz
2026-07-30 13:33 ` [PATCH datacenter-manager/proxmox{,-backup} 00/11] TLS Certificate Rotation Shannon Sterz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DKAZ4JEWITSA.2NSSUZ42SRDQQ@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox