From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 656791FF0E5 for ; Wed, 29 Jul 2026 12:13:52 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id D2F702134B; Wed, 29 Jul 2026 12:13:51 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 29 Jul 2026 12:13:32 +0200 Message-Id: Subject: Re: [PATCH proxmox-backup 04/11] config/server/api: add certificate renewal logic including notifications To: "Lukas Wagner" , X-Mailer: aerc 0.20.0 References: <20260618115443.48618-1-s.sterz@proxmox.com> <20260618115443.48618-5-s.sterz@proxmox.com> In-Reply-To: From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1785319974297 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.135 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: PXZUWHH3C5K2M63KQPK6GH7VGQWSK6NP X-Message-ID-Hash: PXZUWHH3C5K2M63KQPK6GH7VGQWSK6NP X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed Jul 29, 2026 at 12:08 PM CEST, Lukas Wagner wrote: > On Wed Jul 29, 2026 at 11:53 AM CEST, Shannon Sterz wrote: -->8 snip 8<-- >>>> +Proxmox Backup Server will refresh its TLS certificate within the nex= t 30 days. >>> >>> I wonder, would it be possible to include a concrete date here? If I >>> understood it correctly, the first time the user receives this >>> notification, the renewal would be first attempted in 15 days at the >>> earliest, so maybe this should be mentioned. >> >> i can add a line that the earliest a certificate will updated is in X >> days. >> >> adding a date is imo a bit trickier due to localization. as far as i can >> tell, handlebars [1] currently has no date formatting helpers. so either >> we implement our own, which seems orthogonal to this series and probably >> not worth it if we do decide to switch templating engines in the near >> future. or we don't care about localization and simply decide on one >> format (e.g. YYYY-MM-DD). >> >> what do you think? >> >> [1]: https://github.com/sunng87/handlebars-rust/issues/614 > > Notifications are not localized at all right now, so I think if we just > use ISO 8601 (so YYYY-MM-DD), it should be clear enough for most users. ack, i mostly thought of users doing localization themselves by overriding the templates, but will do that then.