public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Shan Shaji" <s.shaji@proxmox.com>
To: "Shannon Sterz" <s.sterz@proxmox.com>, <pdm-devel@lists.proxmox.com>
Subject: Re: [PATCH datacenter-manager/yew-comp 0/3] Allow Editing of Default Realms in PDM
Date: Wed, 24 Jun 2026 15:10:19 +0200	[thread overview]
Message-ID: <DJHAYTSDWCTX.RU6JVC67PASV@proxmox.com> (raw)
In-Reply-To: <20260618102126.177217-1-s.sterz@proxmox.com>

Hi, Thank you for the patches.

Applied the series and did some testing.

* Verified that the `domains.cfg` and `domain.lock` files are generated.
* Updated the comments for the `pam` and `pdm` realms. 
* Updated the `Default` flag and verified that the default realm is selected 
  by default in the login banner. Also, when adding a user, the default
  realm is shown. 

Tested-by: <s.shaji@proxmox.com>

On Thu Jun 18, 2026 at 12:21 PM CEST, Shannon Sterz wrote:
> the goal of this series is to allow editing of the two default realms (pam &
> pdm) in PDM. currently users can neither change the comment nor set these
> realms as the default login realm. this series fixes that and also cleans up
> some comments for proxmox-yew-comp.
>
>
> datacenter-manager:
>
> Shannon Sterz (1):
>   server: api: access: add endpoints for configuring pdm and pam realms
>
>  lib/pdm-api-types/src/lib.rs                  |  96 ++++++++++++++
>  lib/pdm-config/src/domains.rs                 |  37 +++++-
>  server/src/api/access/domains.rs              |  16 +--
>  server/src/api/config/access/mod.rs           |   4 +
>  server/src/api/config/access/pam.rs           | 119 ++++++++++++++++++
>  server/src/api/config/access/pdm.rs           | 119 ++++++++++++++++++
>  .../bin/proxmox-datacenter-privileged-api.rs  |   1 +
>  7 files changed, 375 insertions(+), 17 deletions(-)
>  create mode 100644 server/src/api/config/access/pam.rs
>  create mode 100644 server/src/api/config/access/pdm.rs
>
>
> yew-comp:
>
> Shannon Sterz (2):
>   auth_view: enable editing of default realms
>   auth_view: clarify the documentation of pre-existing properties
>
>  src/auth_view.rs | 61 ++++++++++++++++++++++++++++++++++++++++++------
>  src/utils/mod.rs |  4 ++--
>  2 files changed, 56 insertions(+), 9 deletions(-)
>
>
> Summary over all repositories:
>   9 files changed, 431 insertions(+), 26 deletions(-)





  parent reply	other threads:[~2026-06-24 13:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-18 10:21 [PATCH datacenter-manager/yew-comp 0/3] Allow Editing of Default Realms in PDM Shannon Sterz
2026-06-18 10:21 ` [PATCH datacenter-manager 1/3] server: api: access: add endpoints for configuring pdm and pam realms Shannon Sterz
2026-06-24 12:45   ` Shan Shaji
2026-06-18 10:21 ` [PATCH yew-comp 2/3] auth_view: enable editing of default realms Shannon Sterz
2026-06-24 14:27   ` Shan Shaji
2026-06-18 10:21 ` [PATCH yew-comp 3/3] auth_view: clarify the documentation of pre-existing properties Shannon Sterz
2026-06-24 13:10 ` Shan Shaji [this message]
2026-06-25 12:54 ` Superseded: Re: [PATCH datacenter-manager/yew-comp 0/3] Allow Editing of Default Realms in PDM Shannon Sterz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DJHAYTSDWCTX.RU6JVC67PASV@proxmox.com \
    --to=s.shaji@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    --cc=s.sterz@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal