From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 93A2E1FF13A for ; Wed, 24 Jun 2026 15:10:25 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BB7261868C; Wed, 24 Jun 2026 15:10:24 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 24 Jun 2026 15:10:19 +0200 Message-Id: Subject: Re: [PATCH datacenter-manager/yew-comp 0/3] Allow Editing of Default Realms in PDM From: "Shan Shaji" To: "Shannon Sterz" , X-Mailer: aerc 0.20.0 References: <20260618102126.177217-1-s.sterz@proxmox.com> In-Reply-To: <20260618102126.177217-1-s.sterz@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1782306616649 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.147 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: WYVTL2SRDQRJDJN5CHZ5IB234VTVT3XS X-Message-ID-Hash: WYVTL2SRDQRJDJN5CHZ5IB234VTVT3XS X-MailFrom: s.shaji@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hi, Thank you for the patches. Applied the series and did some testing. * Verified that the `domains.cfg` and `domain.lock` files are generated. * Updated the comments for the `pam` and `pdm` realms.=20 * Updated the `Default` flag and verified that the default realm is selecte= d=20 by default in the login banner. Also, when adding a user, the default realm is shown.=20 Tested-by: On Thu Jun 18, 2026 at 12:21 PM CEST, Shannon Sterz wrote: > the goal of this series is to allow editing of the two default realms (pa= m & > pdm) in PDM. currently users can neither change the comment nor set these > realms as the default login realm. this series fixes that and also cleans= up > some comments for proxmox-yew-comp. > > > datacenter-manager: > > Shannon Sterz (1): > server: api: access: add endpoints for configuring pdm and pam realms > > lib/pdm-api-types/src/lib.rs | 96 ++++++++++++++ > lib/pdm-config/src/domains.rs | 37 +++++- > server/src/api/access/domains.rs | 16 +-- > server/src/api/config/access/mod.rs | 4 + > server/src/api/config/access/pam.rs | 119 ++++++++++++++++++ > server/src/api/config/access/pdm.rs | 119 ++++++++++++++++++ > .../bin/proxmox-datacenter-privileged-api.rs | 1 + > 7 files changed, 375 insertions(+), 17 deletions(-) > create mode 100644 server/src/api/config/access/pam.rs > create mode 100644 server/src/api/config/access/pdm.rs > > > yew-comp: > > Shannon Sterz (2): > auth_view: enable editing of default realms > auth_view: clarify the documentation of pre-existing properties > > src/auth_view.rs | 61 ++++++++++++++++++++++++++++++++++++++++++------ > src/utils/mod.rs | 4 ++-- > 2 files changed, 56 insertions(+), 9 deletions(-) > > > Summary over all repositories: > 9 files changed, 431 insertions(+), 26 deletions(-)