public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Shannon Sterz <s.sterz@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [PATCH yew-comp 3/3] auth_view: clarify the documentation of pre-existing properties
Date: Thu, 18 Jun 2026 12:21:26 +0200	[thread overview]
Message-ID: <20260618102126.177217-4-s.sterz@proxmox.com> (raw)
In-Reply-To: <20260618102126.177217-1-s.sterz@proxmox.com>

so it's a bit clearer what effect these properties have.

Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
 src/auth_view.rs | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/src/auth_view.rs b/src/auth_view.rs
index 8be682a..e46c849 100644
--- a/src/auth_view.rs
+++ b/src/auth_view.rs
@@ -32,10 +32,9 @@ use crate::percent_encoding::percent_encode_component;
 #[derive(PartialEq, Properties)]
 #[builder]
 pub struct AuthView {
-    /// Base API path.
+    /// Base API path to fetch configured realms.
     #[prop_or("/access/domains".into())]
     #[builder(IntoPropValue, into_prop_value)]
-    /// The base url for
     pub base_url: AttrValue,
 
     /// The base URL to edit the default realms (pam, pve, pdm, pbs etc.). Specify `None` if
@@ -44,17 +43,17 @@ pub struct AuthView {
     #[builder(IntoPropValue, into_prop_value)]
     pub edit_default_realms_base_url: Option<AttrValue>,
 
-    /// Allow to add/edit OpenID entries
+    /// Base URL to allow adding and editing of OpenID realms.
     #[builder(IntoPropValue, into_prop_value)]
     #[prop_or_default]
     openid_base_url: Option<AttrValue>,
 
-    /// Allow to add/edit LDAP entries
+    /// Base URL to allow adding and editing of LDAP realms.
     #[builder(IntoPropValue, into_prop_value)]
     #[prop_or_default]
     ldap_base_url: Option<AttrValue>,
 
-    /// Allow to add/edit LDAP entries
+    /// Base URL to allow adding and editing of Active Directory realms.
     #[builder(IntoPropValue, into_prop_value)]
     #[prop_or_default]
     ad_base_url: Option<AttrValue>,
-- 
2.47.3





      parent reply	other threads:[~2026-06-18 10:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-18 10:21 [PATCH datacenter-manager/yew-comp 0/3] Allow Editing of Default Realms in PDM Shannon Sterz
2026-06-18 10:21 ` [PATCH datacenter-manager 1/3] server: api: access: add endpoints for configuring pdm and pam realms Shannon Sterz
2026-06-18 10:21 ` [PATCH yew-comp 2/3] auth_view: enable editing of default realms Shannon Sterz
2026-06-18 10:21 ` Shannon Sterz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260618102126.177217-4-s.sterz@proxmox.com \
    --to=s.sterz@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal