Re: [pdm-devel] [PATCH yew-comp 3/7] utils: factor out task description into own function

From: Dominik Csapak <d.csapak@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
	Proxmox Datacenter Manager development discussion
	<pdm-devel@lists.proxmox.com>
Subject: Re: [pdm-devel] [PATCH yew-comp 3/7] utils: factor out task description into own function
Date: Tue, 21 Jan 2025 10:44:28 +0100	[thread overview]
Message-ID: <70bd9220-83ea-4746-a3d1-a42cfc2a960d@proxmox.com> (raw)
In-Reply-To: <09f7f5f7-309d-4206-8959-c49d247dd251@proxmox.com>

On 1/20/25 18:29, Thomas Lamprecht wrote:
> Am 20.01.25 um 10:29 schrieb Dominik Csapak:
>> +/// Formats the given worker type and id to a Human readable task description
>> +pub fn format_task_description(worker_type: &str, worker_id: Option<&str>) -> String {
>> +    if let Some(text) = lookup_task_description(worker_type, worker_id) {
>> +        text
>> +    } else {
>> +        match worker_id {
>> +            Some(id) => format!("{} {}", worker_type, id),
> 
> nit: please inline the variables into the format string where possible and
> when touching the code anyway.

yeah sorry I overlooked that. Should I send a follow up for this now or
should i leave it and adapt when we have to change it the next time around?

> 
>> +            None => worker_type.to_string(),
>>           }
>>       }
>>   }
> 

_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel