public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH yew-comp/datacenter-manager] ui: implement remote task list
Date: Mon, 20 Jan 2025 10:29:50 +0100	[thread overview]
Message-ID: <20250120093006.927014-1-d.csapak@proxmox.com> (raw)

This series implements a remote task list and includes the remote
running tasks into the globabl running tasks list (if started through
the pdm or caught via caching).

for that i had to adapt the proxmox-yew-comp widget a bit so that
they're more customizable, as well as implement our usual task filters
in the task cache.

the first 2 yew-comp patches could be applied even if the rest of the
series is not, but the remaining patches depend on those for line
numbers etc.

a few things yet to implement
* proper task rendering for the task viewer title
* remote/node filter for remote task list.

I noticed that the task caching could be improved a bit, e.g. we discard
the cache when it's older than some 'max-age' but old (finished!) tasks
will never get updated, they could at most be purged from the cache.

IMHO it does not make sense to control the cache this way with a
'max-age' variable, maybe @Lukas can look over that again and see
if we can cache the tasks better here?
(note that we can't have much above ~1000 tasks in PVE since that
is the number where we purge older ones there. I think we could keep
older tasks for remotes and also just purge them if the number is above
some threshold, maybe a bit higher than what PVE has).

proxmox-yew-comp:

Dominik Csapak (7):
  tasks: make date filter functional
  tasks: load more tasks on end of list
  utils: factor out task description into own function
  running tasks: make TaskListItem renderer configurable
  running tasks: make buttons configurable
  tasks: make columns configurable
  tasks: make the 'show task' action configurable

 src/running_tasks.rs        |  54 ++++++---
 src/running_tasks_button.rs |  15 ++-
 src/tasks.rs                | 221 ++++++++++++++++++++++++++----------
 src/utils.rs                |  24 ++--
 4 files changed, 232 insertions(+), 82 deletions(-)

datacenter-manager:

Dominik Csapak (9):
  server: factor out task filters into `TaskFilters` type
  server: task cache: skip remotes with errors on fetch
  server: task cache: add filter options
  server: task cache: reverse task order
  pdm-client: export PveUpid
  ui: refactor RemoteConfigPanel into own module
  ui: remotes: add tasks to global remote panel
  ui: register pve tasks
  ui: also show running remote tasks in 'running tasks' list

 lib/pdm-api-types/src/lib.rs   |  81 ++++++-
 lib/pdm-client/src/lib.rs      |   2 +
 server/src/api/nodes/tasks.rs  |  80 ++-----
 server/src/api/remote_tasks.rs |  10 +-
 server/src/task_cache.rs       |  77 +++++-
 ui/src/lib.rs                  |   3 +
 ui/src/main.rs                 |  25 +-
 ui/src/main_menu.rs            |   7 +-
 ui/src/remotes/config.rs       | 392 +++++++++++++++++++++++++++++++
 ui/src/remotes/mod.rs          | 413 +++------------------------------
 ui/src/remotes/tasks.rs        | 153 ++++++++++++
 ui/src/tasks.rs                | 101 ++++++++
 ui/src/top_nav_bar.rs          |  54 ++++-
 13 files changed, 932 insertions(+), 466 deletions(-)
 create mode 100644 ui/src/remotes/config.rs
 create mode 100644 ui/src/remotes/tasks.rs
 create mode 100644 ui/src/tasks.rs

-- 
2.39.5



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


             reply	other threads:[~2025-01-20  9:30 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-20  9:29 Dominik Csapak [this message]
2025-01-20  9:29 ` [pdm-devel] [PATCH yew-comp 1/7] tasks: make date filter functional Dominik Csapak
2025-01-20 11:30   ` Thomas Lamprecht
2025-01-20 12:10     ` Dominik Csapak
2025-01-21  8:33       ` Thomas Lamprecht
2025-01-21  9:46         ` Dominik Csapak
2025-01-20  9:29 ` [pdm-devel] [PATCH yew-comp 2/7] tasks: load more tasks on end of list Dominik Csapak
2025-01-20 17:29   ` Thomas Lamprecht
2025-01-21  9:43     ` Dominik Csapak
2025-01-20  9:29 ` [pdm-devel] [PATCH yew-comp 3/7] utils: factor out task description into own function Dominik Csapak
2025-01-20 17:29   ` Thomas Lamprecht
2025-01-21  9:44     ` Dominik Csapak
2025-01-20  9:29 ` [pdm-devel] [PATCH yew-comp 4/7] running tasks: make TaskListItem renderer configurable Dominik Csapak
2025-01-20  9:29 ` [pdm-devel] [PATCH yew-comp 5/7] running tasks: make buttons configurable Dominik Csapak
2025-01-20  9:29 ` [pdm-devel] [PATCH yew-comp 6/7] tasks: make columns configurable Dominik Csapak
2025-01-20 17:37   ` Thomas Lamprecht
2025-01-20  9:29 ` [pdm-devel] [PATCH yew-comp 7/7] tasks: make the 'show task' action configurable Dominik Csapak
2025-01-20  9:29 ` [pdm-devel] [PATCH datacenter-manager 1/9] server: factor out task filters into `TaskFilters` type Dominik Csapak
2025-01-20 17:42   ` Thomas Lamprecht
2025-01-20  9:29 ` [pdm-devel] [PATCH datacenter-manager 2/9] server: task cache: skip remotes with errors on fetch Dominik Csapak
2025-01-20 17:45   ` Thomas Lamprecht
2025-01-21  8:29     ` Dietmar Maurer
2025-01-20  9:30 ` [pdm-devel] [PATCH datacenter-manager 3/9] server: task cache: add filter options Dominik Csapak
2025-01-20  9:30 ` [pdm-devel] [PATCH datacenter-manager 4/9] server: task cache: reverse task order Dominik Csapak
2025-01-20  9:30 ` [pdm-devel] [PATCH datacenter-manager 5/9] pdm-client: export PveUpid Dominik Csapak
2025-01-20  9:30 ` [pdm-devel] [PATCH datacenter-manager 6/9] ui: refactor RemoteConfigPanel into own module Dominik Csapak
2025-01-20  9:30 ` [pdm-devel] [PATCH datacenter-manager 7/9] ui: remotes: add tasks to global remote panel Dominik Csapak
2025-01-20  9:30 ` [pdm-devel] [PATCH datacenter-manager 8/9] ui: register pve tasks Dominik Csapak
2025-01-20  9:30 ` [pdm-devel] [PATCH datacenter-manager 9/9] ui: also show running remote tasks in 'running tasks' list Dominik Csapak
2025-01-20 11:27 ` [pdm-devel] applied: [PATCH yew-comp/datacenter-manager] ui: implement remote task list Dietmar Maurer
2025-01-20 11:34   ` Thomas Lamprecht
2025-01-21  8:41 ` [pdm-devel] " Lukas Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250120093006.927014-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal