[PATCH datacenter-manager/yew-widget-toolkit 0/2] auto-installer: set proper tooltip for command line show/hide

[PATCH datacenter-manager/yew-widget-toolkit 0/2] auto-installer: set proper tooltip for command line show/hide

[Christoph Heiss]

When (re-)generating a new secret for an auto-installer token, the
command field has a show/hide button, to reveal the contents if wanted.
The tooltip for that button fixed to "Show Password" and "Hide
Password", depending on the action.

This series makes that overridable and sets an appropriate tooltip for
the command line field in PDM.

Diffstat
========

proxmox-yew-widget-toolkit:

Christoph Heiss (1):
  form: field: make peek icon tooltip for password customizable

 src/widget/form/field.rs | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

proxmox-datacenter-manager:

Christoph Heiss (1):
  ui: auto-installer: set correct tooltip for command line peek icon

 ui/src/remotes/auto_installer/prepared_answer_form.rs | 1 +
 1 file changed, 1 insertion(+)

-- 

[PATCH yew-widget-toolkit 1/2] form: field: make peek icon tooltip overridable

[Christoph Heiss]

A field with `InputType::Password` may also be useful in other
contexts, which don't necessarily need to be passwords.

Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
 src/widget/form/field.rs | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/widget/form/field.rs b/src/widget/form/field.rs
index 1d694b0..ee49f08 100644
--- a/src/widget/form/field.rs
+++ b/src/widget/form/field.rs
@@ -184,6 +184,10 @@ pub struct Field {
     #[builder]
     pub show_peek_icon: bool,
 
+    #[prop_or((tr!("Show Password").into(), tr!("Hide Password").into()))]
+    #[builder]
+    pub peek_icon_tip: (AttrValue, AttrValue),
+
     /// Icons to show on the left (false) or right(true) side of the input
     #[prop_or_default]
     #[builder]
@@ -481,9 +485,9 @@ impl ManagedField for StandardField {
                     "pwt-pointer"
                 );
                 let tooltip_text = if is_hidden {
-                    tr!("Show Password")
+                    &props.peek_icon_tip.0
                 } else {
-                    tr!("Hide Password")
+                    &props.peek_icon_tip.1
                 };
                 Some(Tooltip::new(html! { <i {class} {onclick}/> }).tip(tooltip_text))
             } else {
-- 
2.53.0

[PATCH datacenter-manager 2/2] ui: auto-installer: use correct tooltip for command line peek icon

[Christoph Heiss]

The default is "Show Password" and "Hide Password", respectively, which
isn't correct in this case.

Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
Depends on a bump of proxmox-yew-widget-toolkit with the previous patch
applied.

 ui/src/remotes/auto_installer/prepared_answer_form.rs | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ui/src/remotes/auto_installer/prepared_answer_form.rs b/ui/src/remotes/auto_installer/prepared_answer_form.rs
index 560503a4..84cb5ea4 100644
--- a/ui/src/remotes/auto_installer/prepared_answer_form.rs
+++ b/ui/src/remotes/auto_installer/prepared_answer_form.rs
@@ -1041,6 +1041,7 @@ pub fn render_show_secret_dialog(
                     Field::new()
                         .input_type(InputType::Password)
                         .class(FlexFit)
+                        .peek_icon_tip((tr!("Show Command Line").into(), tr!("Hide Command Line").into()))
                         .value(commandline.to_owned())
                         .read_only(true),
                 )
-- 
2.53.0

Re: [PATCH datacenter-manager/yew-widget-toolkit 0/2] auto-installer: set proper tooltip for command line show/hide

[Dominik Csapak]

i get what the end result should be, but i don't think we should
override the 'password' feature with something else.

another way to do this would be to have a custom trigger
on the use site and show '******' manually?


i just don't believe we will have many uses for changing this tooltip..

Re: [PATCH datacenter-manager/yew-widget-toolkit 0/2] auto-installer: set proper tooltip for command line show/hide

[Thomas Lamprecht]

Am 28.05.26 um 13:19 schrieb Dominik Csapak:
> i get what the end result should be, but i don't think we should
> override the 'password' feature with something else.

Why not? A generic "this includes a secret" field seems to be a good
fit for both? Why duplicate that? (honest question)

> 
> another way to do this would be to have a custom trigger
> on the use site and show '******' manually?
> 
> 
> i just don't believe we will have many uses for changing this tooltip..
Sure, but what's the cost of having it vs. duplicating the field for
just having custom tooltips?

Re: [PATCH datacenter-manager/yew-widget-toolkit 0/2] auto-installer: set proper tooltip for command line show/hide

[Dominik Csapak]

On 5/28/26 2:15 PM, Thomas Lamprecht wrote:
> Am 28.05.26 um 13:19 schrieb Dominik Csapak:
>> i get what the end result should be, but i don't think we should
>> override the 'password' feature with something else.
> 
> Why not? A generic "this includes a secret" field seems to be a good
> fit for both? Why duplicate that? (honest question)
> 

Judging from the past, we generally don't have any such fields where
it's not a password, so I don't think we'll use this often.

I think we have to be careful what we add to the public API of
the widgets, otherwise we'll add a ton of stuff we don't (often) use.

E.g. the next one maybe needs a different icon for the peek trigger,
or want it left, etc.

Maybe the answer here could also be that the peek trigger be a custom
one? then it's generic enough for my taste to include it.

E.g. something like (would have to flesh out the details of course)

pub peek_trigger: Option<(Trigger, bool)>

(which could get a sensible default implementation)

this way we could also get rid of the 'show_peek_icon' property
and just set it to None on the use site

Don't get me wrong, we can add this property if you prefer that.

>>
>> another way to do this would be to have a custom trigger
>> on the use site and show '******' manually?
>>
>>
>> i just don't believe we will have many uses for changing this tooltip..
> Sure, but what's the cost of having it vs. duplicating the field for
> just having custom tooltips?