From: Christian Ebner <c.ebner@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [PATCH datacenter-manager] ui: auto-installer: improve auto-installer command line template
Date: Tue, 26 May 2026 15:22:48 +0200 [thread overview]
Message-ID: <20260526132248.531503-1-c.ebner@proxmox.com> (raw)
The auto-generated command line for the auto-installer to be copied
by an user needs to be adapted to include the source image. An
unexpecting user might just copy the command and past it, running
into a not so telling: `Error: free-standing argument is missing`.
Make it clearer that this is a template only and add a template input
file, which leads to the following more telling error messages on
missing or unrelated input files:
- `Error: Source file "SOURCE-INPUT-FILE" does not exist.`
- `Error: The source ISO file is not able to be installed automatically.
Please try a more current one.`
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
ui/src/remotes/auto_installer/prepared_answer_form.rs | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ui/src/remotes/auto_installer/prepared_answer_form.rs b/ui/src/remotes/auto_installer/prepared_answer_form.rs
index c1d2bab..15be027 100644
--- a/ui/src/remotes/auto_installer/prepared_answer_form.rs
+++ b/ui/src/remotes/auto_installer/prepared_answer_form.rs
@@ -933,7 +933,7 @@ pub fn render_show_secret_dialog(
pdm_origin().unwrap_or_else(|| "https://pdm.example.com:8443".to_owned())
);
let commandline = format!(
- "proxmox-auto-install-assistant prepare-iso --fetch-from http --url {answer_url} --answer-auth-token {token}",
+ "proxmox-auto-install-assistant prepare-iso --fetch-from http --url {answer_url} --answer-auth-token {token} SOURCE-INPUT-FILE",
);
let copy_commandline_view = Container::new()
@@ -960,7 +960,7 @@ pub fn render_show_secret_dialog(
move |_| copy_text_to_clipboard(&commandline)
}),
)
- .tip(tr!("Copy command line to clipboard.")),
+ .tip(tr!("Copy template command line to clipboard. Adapt SOURCE-INPUT-FILE to your needs.")),
),
);
--
2.47.3
next reply other threads:[~2026-05-26 13:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 13:22 Christian Ebner [this message]
2026-05-26 14:17 ` applied: [PATCH datacenter-manager] ui: auto-installer: improve auto-installer command line template Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260526132248.531503-1-c.ebner@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox