From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pdm-devel@lists.proxmox.com, Christian Ebner <c.ebner@proxmox.com>
Subject: applied: [PATCH datacenter-manager] ui: auto-installer: improve auto-installer command line template
Date: Tue, 26 May 2026 16:17:51 +0200 [thread overview]
Message-ID: <177980504066.2276930.238054849484805170.b4-ty@b4> (raw)
In-Reply-To: <20260526132248.531503-1-c.ebner@proxmox.com>
On Tue, 26 May 2026 15:22:48 +0200, Christian Ebner wrote:
> The auto-generated command line for the auto-installer to be copied
> by an user needs to be adapted to include the source image. An
> unexpecting user might just copy the command and past it, running
> into a not so telling: `Error: free-standing argument is missing`.
>
> Make it clearer that this is a template only and add a template input
> file, which leads to the following more telling error messages on
> missing or unrelated input files:
> - `Error: Source file "SOURCE-INPUT-FILE" does not exist.`
> - `Error: The source ISO file is not able to be installed automatically.
> Please try a more current one.`
>
> [...]
Applied, thanks!
I renamed the placeholder to INPUT.iso (the .iso hints the file type) and
reword tip to "Replace ..." since "adapt" reads like modifying the file
itself.
[1/1] ui: auto-installer: improve auto-installer command line template
commit: e41051695cab1dfeb31c46e0db700e9f58254170
prev parent reply other threads:[~2026-05-26 14:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 13:22 [PATCH datacenter-manager] ui: auto-installer: improve auto-installer command line template Christian Ebner
2026-05-26 14:17 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177980504066.2276930.238054849484805170.b4-ty@b4 \
--to=t.lamprecht@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox