From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id C3B771FF146 for ; Tue, 26 May 2026 15:23:04 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9BB1A1FB8F; Tue, 26 May 2026 15:23:04 +0200 (CEST) From: Christian Ebner To: pdm-devel@lists.proxmox.com Subject: [PATCH datacenter-manager] ui: auto-installer: improve auto-installer command line template Date: Tue, 26 May 2026 15:22:48 +0200 Message-ID: <20260526132248.531503-1-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779801755742 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.068 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record WEIRD_PORT 0.001 Uses non-standard port number for HTTP Message-ID-Hash: JGDATYGPPYNQHUP6GOWULI52H2QRNCVE X-Message-ID-Hash: JGDATYGPPYNQHUP6GOWULI52H2QRNCVE X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The auto-generated command line for the auto-installer to be copied by an user needs to be adapted to include the source image. An unexpecting user might just copy the command and past it, running into a not so telling: `Error: free-standing argument is missing`. Make it clearer that this is a template only and add a template input file, which leads to the following more telling error messages on missing or unrelated input files: - `Error: Source file "SOURCE-INPUT-FILE" does not exist.` - `Error: The source ISO file is not able to be installed automatically. Please try a more current one.` Signed-off-by: Christian Ebner --- ui/src/remotes/auto_installer/prepared_answer_form.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/src/remotes/auto_installer/prepared_answer_form.rs b/ui/src/remotes/auto_installer/prepared_answer_form.rs index c1d2bab..15be027 100644 --- a/ui/src/remotes/auto_installer/prepared_answer_form.rs +++ b/ui/src/remotes/auto_installer/prepared_answer_form.rs @@ -933,7 +933,7 @@ pub fn render_show_secret_dialog( pdm_origin().unwrap_or_else(|| "https://pdm.example.com:8443".to_owned()) ); let commandline = format!( - "proxmox-auto-install-assistant prepare-iso --fetch-from http --url {answer_url} --answer-auth-token {token}", + "proxmox-auto-install-assistant prepare-iso --fetch-from http --url {answer_url} --answer-auth-token {token} SOURCE-INPUT-FILE", ); let copy_commandline_view = Container::new() @@ -960,7 +960,7 @@ pub fn render_show_secret_dialog( move |_| copy_text_to_clipboard(&commandline) }), ) - .tip(tr!("Copy command line to clipboard.")), + .tip(tr!("Copy template command line to clipboard. Adapt SOURCE-INPUT-FILE to your needs.")), ), ); -- 2.47.3