Re: [PATCH proxmox{,-backup,-datacenter-manager} v2 0/5] factor system report into shared crate

[Christian Ebner <c.ebner@proxmox.com>]

On 7/30/26 12:13 PM, Erik Fastermann wrote:
> This series moves the system report logic that was duplicated in
> PBS and PDM into a new shared proxmox-system-report crate.
> 
> proxmox:
>    Adds the proxmox-system-report crate holding the common file,
>    command and function collection, the unified section order
>    (FILES, COMMANDS, FUNCTIONS) and the merged set of general commands
>    run on every product.
> 
> proxmox-backup, proxmox-datacenter-manager:
>    Drop the duplicated logic and generate the report through the shared
>    crate, passing only their product specific files, commands and
>    functions.
> 
> The report content stays the same apart from two intentional effects
> of sharing one implementation: the top-level section order is now the
> same for both products, and the general command set is the union of
> what each ran before. PDM additionally emits FILES first now instead
> of last. Product specific entries are untouched.

Apart from a tiny nit consider:

Reviewed-by: Christian Ebner <c.ebner@proxmox.com>
Tested-by: Christian Ebner <c.ebner@proxmox.com>