public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Erik Fastermann <e.fastermann@proxmox.com>
To: pbs-devel@lists.proxmox.com, pdm-devel@lists.proxmox.com
Cc: Erik Fastermann <e.fastermann@proxmox.com>
Subject: [PATCH proxmox{,-backup,-datacenter-manager} v2 0/5] factor system report into shared crate
Date: Thu, 30 Jul 2026 12:13:44 +0200	[thread overview]
Message-ID: <20260730101349.217371-1-e.fastermann@proxmox.com> (raw)

This series moves the system report logic that was duplicated in
PBS and PDM into a new shared proxmox-system-report crate.

proxmox:
  Adds the proxmox-system-report crate holding the common file,
  command and function collection, the unified section order
  (FILES, COMMANDS, FUNCTIONS) and the merged set of general commands
  run on every product.

proxmox-backup, proxmox-datacenter-manager:
  Drop the duplicated logic and generate the report through the shared
  crate, passing only their product specific files, commands and
  functions.

The report content stays the same apart from two intentional effects
of sharing one implementation: the top-level section order is now the
same for both products, and the general command set is the union of
what each ran before. PDM additionally emits FILES first now instead
of last. Product specific entries are untouched.


Changes since v1:
* Use version 1.0.0 for the new crate
* Add Debian changelog and control files for the new crate
* Use only 2026 as the year for the copyright notice of the new crate
* Rename CommandSpec types and update the doc comment
* Use the common_* and project_* prefixes for the related functions
* Add the previously missing report dependencies as extra commits for
  PDM and PBS
* Add the newly required report dependencies to PDM
* Add librust-proxmox-system-report-1+default-dev as a dependency to
  PDM and PBS
* Add a commented out local path override for proxmox-system-report to
  the `Cargo.toml` file in PDM and PBS

Thank you @Christian Ebner for the feedback on the first version.


proxmox:

Erik Fastermann (1):
  system-report: add crate for shared report generation

 Cargo.toml                                 |   2 +
 proxmox-system-report/Cargo.toml           |  16 ++
 proxmox-system-report/debian/changelog     |   6 +
 proxmox-system-report/debian/control       |  36 ++++
 proxmox-system-report/debian/copyright     |  18 ++
 proxmox-system-report/debian/debcargo.toml |   7 +
 proxmox-system-report/src/lib.rs           | 239 +++++++++++++++++++++
 7 files changed, 324 insertions(+)
 create mode 100644 proxmox-system-report/Cargo.toml
 create mode 100644 proxmox-system-report/debian/changelog
 create mode 100644 proxmox-system-report/debian/control
 create mode 100644 proxmox-system-report/debian/copyright
 create mode 100644 proxmox-system-report/debian/debcargo.toml
 create mode 100644 proxmox-system-report/src/lib.rs


proxmox-backup:

Erik Fastermann (2):
  d/control: depend on tools used by the system report
  report: use shared proxmox-system-report crate

 Cargo.toml           |   3 +
 debian/control       |   4 +
 src/server/report.rs | 217 ++++---------------------------------------
 3 files changed, 24 insertions(+), 200 deletions(-)


proxmox-datacenter-manager:

Erik Fastermann (2):
  d/control: depend on tools used by the system report
  report: use shared proxmox-system-report crate

 Cargo.toml           |   2 +
 debian/control       |  10 ++-
 server/Cargo.toml    |   1 +
 server/src/report.rs | 198 +------------------------------------------
 4 files changed, 16 insertions(+), 195 deletions(-)


Summary over all repositories:
  14 files changed, 364 insertions(+), 395 deletions(-)

-- 
Generated by murpp 0.11.0



             reply	other threads:[~2026-07-30 10:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-30 10:13 Erik Fastermann [this message]
2026-07-30 10:13 ` [PATCH proxmox v2 1/5] system-report: add crate for shared report generation Erik Fastermann
2026-07-30 10:13 ` [PATCH proxmox-backup v2 2/5] d/control: depend on tools used by the system report Erik Fastermann
2026-07-30 10:13 ` [PATCH proxmox-backup v2 3/5] report: use shared proxmox-system-report crate Erik Fastermann
2026-07-30 10:13 ` [PATCH proxmox-datacenter-manager v2 4/5] d/control: depend on tools used by the system report Erik Fastermann
2026-07-30 10:13 ` [PATCH proxmox-datacenter-manager v2 5/5] report: use shared proxmox-system-report crate Erik Fastermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260730101349.217371-1-e.fastermann@proxmox.com \
    --to=e.fastermann@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal