public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox v3 05/11] s3-client: honor response header directed retry delays
Date: Fri, 13 Nov 2026 09:13:34 +0100	[thread overview]
Message-ID: <fe28c273-4297-496d-8be9-475e374084c8@proxmox.com> (raw)
In-Reply-To: <20261112180119.660923-6-c.ebner@proxmox.com>

On 11/12/26 7:01 PM, Christian Ebner wrote:
> S3 API servers can tell clients when they expect to have capacity
> available again via the x-amz-retry-after header, given in
> milliseconds. Retrying earlier is likely to fail again and only adds
> load, so try to honor these delays on retry.
> 
> Use the server's requested delay instead of the computed backoff, but
> never wait less than the backoff and at most 5 seconds longer, so a
> misbehaving server cannot stall requests for a long time. No jitter
> is applied, the server is expected to randomize the delay itself.
> 
> This follows the AWS SDKs implementation guide.
> 
> Link: https://docs.aws.amazon.com/sdkref/latest/guide/feature-retry-behavior.html
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
Seems this is incomplete and it should check the Retry-After header as 
fallback as well. Some providers do not use x-amz-retry-after header, 
e.g. Backblaze B2 https://www.backblaze.com/docs/cloud-storage-rate-limits

Will add this and send a new version of the patches.




  reply	other threads:[~2026-11-13  8:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-12 18:01 [PATCH proxmox{,-backup} v3 00/11] fix #7606: verify: s3: handle transient fetch errors and add retry Christian Ebner
2026-11-12 18:01 ` [PATCH proxmox v3 01/11] s3-client: also retry requests on bad gateway responses Christian Ebner
2026-11-12 18:01 ` [PATCH proxmox v3 02/11] s3-client: distinguish transient errors and throttled requests Christian Ebner
2026-11-12 18:01 ` [PATCH proxmox v3 03/11] s3-client: detect throttling request from the response body on error Christian Ebner
2026-11-12 18:01 ` [PATCH proxmox v3 04/11] s3-client: avoid retry bursts by adding jitter to retry backoff delay Christian Ebner
2026-11-12 18:01 ` [PATCH proxmox v3 05/11] s3-client: honor response header directed retry delays Christian Ebner
2026-11-13  8:13   ` Christian Ebner [this message]
2026-11-12 18:01 ` [PATCH proxmox v3 06/11] s3-client: add additional backoff delay between upload retries Christian Ebner
2026-11-12 18:01 ` [PATCH proxmox v3 07/11] s3-client: add helper to fetch object contents with retry Christian Ebner
2026-11-12 18:01 ` [PATCH proxmox-backup v3 08/11] s3: retry fetching object contents on body collection errors Christian Ebner
2026-11-12 18:01 ` [PATCH proxmox-backup v3 09/11] datastore: snapshot: propagate errors in manifest update callback Christian Ebner
2026-11-12 18:01 ` [PATCH proxmox-backup v3 10/11] fix #7606: verify: s3: handle transient chunk load errors Christian Ebner
2026-11-12 18:01 ` [PATCH proxmox-backup v3 11/11] verify: s3: stop early if the endpoint appears unreachable Christian Ebner
2026-11-13 14:23 ` superseded: [PATCH proxmox{,-backup} v3 00/11] fix #7606: verify: s3: handle transient fetch errors and add retry Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fe28c273-4297-496d-8be9-475e374084c8@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal