From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox v3 06/11] s3-client: add additional backoff delay between upload retries
Date: Thu, 12 Nov 2026 19:01:14 +0100 [thread overview]
Message-ID: <20261112180119.660923-7-c.ebner@proxmox.com> (raw)
In-Reply-To: <20261112180119.660923-1-c.ebner@proxmox.com>
Uploads are repeated immediately if the server reports a conflicting
concurrent operation on the same object. Retrying right away gives a
concurrent operation no time to finish and adds load to a server
which already failed to handle the request.
Wait for the jittered transient backoff before repeating the upload,
as done for the individual requests.
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
proxmox-s3-client/src/client.rs | 1 +
1 file changed, 1 insertion(+)
diff --git a/proxmox-s3-client/src/client.rs b/proxmox-s3-client/src/client.rs
index b094a58d..e0e01d81 100644
--- a/proxmox-s3-client/src/client.rs
+++ b/proxmox-s3-client/src/client.rs
@@ -1027,6 +1027,7 @@ impl S3Client {
}
}
}
+ tokio::time::sleep(retry_backoff_with_jitter(RetryReason::Transient, retry)).await;
}
Ok(false)
}
--
2.47.3
next prev parent reply other threads:[~2026-11-12 18:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 18:01 [PATCH proxmox{,-backup} v3 00/11] fix #7606: verify: s3: handle transient fetch errors and add retry Christian Ebner
2026-11-12 18:01 ` [PATCH proxmox v3 01/11] s3-client: also retry requests on bad gateway responses Christian Ebner
2026-11-12 18:01 ` [PATCH proxmox v3 02/11] s3-client: distinguish transient errors and throttled requests Christian Ebner
2026-11-12 18:01 ` [PATCH proxmox v3 03/11] s3-client: detect throttling request from the response body on error Christian Ebner
2026-11-12 18:01 ` [PATCH proxmox v3 04/11] s3-client: avoid retry bursts by adding jitter to retry backoff delay Christian Ebner
2026-11-12 18:01 ` [PATCH proxmox v3 05/11] s3-client: honor response header directed retry delays Christian Ebner
2026-11-13 8:13 ` Christian Ebner
2026-11-12 18:01 ` Christian Ebner [this message]
2026-11-12 18:01 ` [PATCH proxmox v3 07/11] s3-client: add helper to fetch object contents with retry Christian Ebner
2026-11-12 18:01 ` [PATCH proxmox-backup v3 08/11] s3: retry fetching object contents on body collection errors Christian Ebner
2026-11-12 18:01 ` [PATCH proxmox-backup v3 09/11] datastore: snapshot: propagate errors in manifest update callback Christian Ebner
2026-11-12 18:01 ` [PATCH proxmox-backup v3 10/11] fix #7606: verify: s3: handle transient chunk load errors Christian Ebner
2026-11-12 18:01 ` [PATCH proxmox-backup v3 11/11] verify: s3: stop early if the endpoint appears unreachable Christian Ebner
2026-11-13 14:23 ` superseded: [PATCH proxmox{,-backup} v3 00/11] fix #7606: verify: s3: handle transient fetch errors and add retry Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261112180119.660923-7-c.ebner@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox