From: Christian Ebner <c.ebner@proxmox.com>
To: Jonas Theisen <j.theisen@proxmox.com>, pbs-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox-backup v3 10/10] ui: create datastore: add enable checkboxes for {GC, prune}
Date: Thu, 15 Oct 2026 13:14:22 +0200 [thread overview]
Message-ID: <cb145217-2e9e-4c78-95ef-2be11962f66b@proxmox.com> (raw)
In-Reply-To: <20261009145445.282494-8-j.theisen@proxmox.com>
On 10/9/26 4:55 PM, Jonas Theisen wrote:
> To allow users to disable GC and prune jobs at creation of
> a datastore without setting the schedule to none, this patch
> adds the necessary checkboxes and logic.
I would prefer to not add the checkboxes at all here, as they do lead to
the field layouts being shifted and are a bit counter productive, as
ideally a user is primed by the creation dialog to setup valid prune and
garbage collection schedules already.
Not setting these is already supported, but a bit hidden on purpose. We
might expose the x button for clearing which shows up when changing the
value by default already.
> This patch depends on a changed API endpoint to allow
> a creation of the datastore without the prune job.
>
> Signed-off-by: Jonas Theisen <j.theisen@proxmox.com>
> ---
prev parent reply other threads:[~2026-10-15 11:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 14:54 [PATCH proxmox-backup v3 03/10] ui: prune job: align prune edit window to other "Enable" checkboxes Jonas Theisen
2026-10-09 14:54 ` [PATCH proxmox-backup v3 04/10] api: prune job: align prune job schedule to other jobs Jonas Theisen
2026-10-15 11:14 ` Christian Ebner
2026-10-09 14:54 ` [PATCH proxmox-backup v3 05/10] fix #7904: api: implement "disable" for {sync,verify,tape,GC} jobs Jonas Theisen
2026-10-15 11:14 ` Christian Ebner
2026-10-09 14:54 ` [PATCH proxmox-backup v3 06/10] fix #7904: ui: job edit: introduce "Enable" checkbox " Jonas Theisen
2026-10-15 11:14 ` Christian Ebner
2026-10-09 14:54 ` [PATCH proxmox-backup v3 07/10] ui: improve visibility of disabled {sync,verify,tape,GC,prune} jobs on the overview page Jonas Theisen
2026-10-09 14:54 ` [PATCH proxmox-backup v3 08/10] ui: calendar-event: remove clear button from calendar selector Jonas Theisen
2026-10-09 14:54 ` [PATCH proxmox-backup v3 09/10] api: create datastore: allow creation without prune job Jonas Theisen
2026-10-09 14:54 ` [PATCH proxmox-backup v3 10/10] ui: create datastore: add enable checkboxes for {GC, prune} Jonas Theisen
2026-10-15 11:14 ` Christian Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb145217-2e9e-4c78-95ef-2be11962f66b@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=j.theisen@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox