From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 2D45F1FF0DF for ; Thu, 15 Oct 2026 13:14:28 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 646FA20CE3; Thu, 15 Oct 2026 13:14:27 +0200 (CEST) Message-ID: Date: Thu, 15 Oct 2026 13:14:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH proxmox-backup v3 10/10] ui: create datastore: add enable checkboxes for {GC, prune} To: Jonas Theisen , pbs-devel@lists.proxmox.com References: <20261009145445.282494-1-j.theisen@proxmox.com> <20261009145445.282494-8-j.theisen@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20261009145445.282494-8-j.theisen@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1792062863110 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.513 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ITLGWCSRUN3D42UFZMVQ6A3D7PIHVDOW X-Message-ID-Hash: ITLGWCSRUN3D42UFZMVQ6A3D7PIHVDOW X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 10/9/26 4:55 PM, Jonas Theisen wrote: > To allow users to disable GC and prune jobs at creation of > a datastore without setting the schedule to none, this patch > adds the necessary checkboxes and logic. I would prefer to not add the checkboxes at all here, as they do lead to the field layouts being shifted and are a bit counter productive, as ideally a user is primed by the creation dialog to setup valid prune and garbage collection schedules already. Not setting these is already supported, but a bit hidden on purpose. We might expose the x button for clearing which shows up when changing the value by default already. > This patch depends on a changed API endpoint to allow > a creation of the datastore without the prune job. > > Signed-off-by: Jonas Theisen > ---