From: Christian Ebner <c.ebner@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Hannes Laimer <h.laimer@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 6/7] ui: add run-on-mount checkbox to SyncJob form
Date: Tue, 4 Feb 2025 15:46:38 +0100 [thread overview]
Message-ID: <c806ac63-9a96-4799-b899-8dba90bcdd3c@proxmox.com> (raw)
In-Reply-To: <20250116064543.74619-7-h.laimer@proxmox.com>
On 1/16/25 07:45, Hannes Laimer wrote:
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
> www/window/SyncJobEdit.js | 23 ++++++++++++++++++++++-
> 1 file changed, 22 insertions(+), 1 deletion(-)
>
> diff --git a/www/window/SyncJobEdit.js b/www/window/SyncJobEdit.js
> index bcd2f2fb2..2b3660ed9 100644
> --- a/www/window/SyncJobEdit.js
> +++ b/www/window/SyncJobEdit.js
> @@ -177,7 +177,7 @@ Ext.define('PBS.window.SyncJobEdit', {
> fieldLabel: gettext('Sync Schedule'),
> xtype: 'pbsCalendarEvent',
> name: 'schedule',
> - emptyText: gettext('none (disabled)'),
> + emptyText: gettext('none'),
> cbind: {
> deleteEmpty: '{!isCreate}',
> value: '{scheduleValue}',
> @@ -191,6 +191,27 @@ Ext.define('PBS.window.SyncJobEdit', {
> submitAutoScaledSizeUnit: true,
> // NOTE: handle deleteEmpty in onGetValues due to bandwidth field having a cbind too
> },
> + {
> + fieldLabel: gettext('Run when mounted'),
> + xtype: 'proxmoxcheckbox',
> + name: 'run-on-mount',
> + autoEl: {
> + tag: 'div',
> + 'data-qtip': gettext('Run this job when a relevant removable datastore is mounted'),
> + },
> + uncheckedValue: false,
> + value: false,
> + listeners: {
> + change: function(checkbox, runOnMount) {
> + let me = this;
> + let form = me.up('pbsSyncJobEdit');
> + let scheduleField = form.down('field[name=schedule]');
> + if (runOnMount) {
> + scheduleField.clearValue();
clearing the schedule field's value is not enough. Clicking the checkbox
should also disable that field, as otherwise one can re-add a schedule
after setting the flag. Further, if this is a requirement, setting and
getting the sync job config should also include a check for that?
Although I'm not sure it is really required for a sync job which runs on
mount to not be also be able to run on schedule?
> + }
> + },
> + },
> + },
> ],
>
> column2: [
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-02-04 14:47 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 6:45 [pbs-devel] [PATCH proxmox/proxmox-backup 0/7] trigger sync jobs on mount Hannes Laimer
2025-01-16 6:45 ` [pbs-devel] [PATCH proxmox 1/7] rest-server: add function that returns a join handle for spawn Hannes Laimer
2025-02-04 14:18 ` Christian Ebner
2025-01-16 6:45 ` [pbs-devel] [PATCH proxmox-backup 2/7] api types: add run-on-mount flag to SyncJobConfig Hannes Laimer
2025-02-04 14:24 ` Christian Ebner
2025-02-28 8:21 ` Hannes Laimer
2025-01-16 6:45 ` [pbs-devel] [PATCH proxmox-backup 3/7] api: admin: run configured sync jobs when a datastore is mounted Hannes Laimer
2025-02-04 14:33 ` Christian Ebner
2025-02-28 8:18 ` Hannes Laimer
2025-02-28 12:13 ` Christian Ebner
2025-01-16 6:45 ` [pbs-devel] [PATCH proxmox-backup 4/7] api: admin: trigger sync jobs only on datastore mount Hannes Laimer
2025-02-04 14:34 ` Christian Ebner
2025-05-15 11:33 ` Hannes Laimer
2025-05-15 11:45 ` Christian Ebner
2025-01-16 6:45 ` [pbs-devel] [PATCH proxmox-backup 5/7] bin: manager: run uuid_mount/mount tasks on the proxy Hannes Laimer
2025-02-04 14:41 ` Christian Ebner
2025-01-16 6:45 ` [pbs-devel] [PATCH proxmox-backup 6/7] ui: add run-on-mount checkbox to SyncJob form Hannes Laimer
2025-02-04 14:46 ` Christian Ebner [this message]
2025-02-28 11:54 ` Hannes Laimer
2025-02-04 15:22 ` Christian Ebner
2025-01-16 6:45 ` [pbs-devel] [PATCH proxmox-backup 7/7] ui: add task title for triggering sync jobs Hannes Laimer
2025-02-04 14:54 ` [pbs-devel] [PATCH proxmox/proxmox-backup 0/7] trigger sync jobs on mount Christian Ebner
2025-02-28 8:22 ` Hannes Laimer
2025-05-15 12:43 ` Hannes Laimer
-- strict thread matches above, loose matches on Subject: below --
2024-12-11 10:40 [pbs-devel] [PATCH proxmox-backup " Hannes Laimer
2024-12-11 10:40 ` [pbs-devel] [PATCH proxmox-backup 6/7] ui: add run-on-mount checkbox to SyncJob form Hannes Laimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c806ac63-9a96-4799-b899-8dba90bcdd3c@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal