From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 80D631FF168 for ; Tue, 4 Feb 2025 15:47:12 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 01C3F1982B; Tue, 4 Feb 2025 15:47:12 +0100 (CET) Message-ID: Date: Tue, 4 Feb 2025 15:46:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox Backup Server development discussion , Hannes Laimer References: <20250116064543.74619-1-h.laimer@proxmox.com> <20250116064543.74619-7-h.laimer@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20250116064543.74619-7-h.laimer@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.031 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup 6/7] ui: add run-on-mount checkbox to SyncJob form X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 1/16/25 07:45, Hannes Laimer wrote: > Signed-off-by: Hannes Laimer > --- > www/window/SyncJobEdit.js | 23 ++++++++++++++++++++++- > 1 file changed, 22 insertions(+), 1 deletion(-) > > diff --git a/www/window/SyncJobEdit.js b/www/window/SyncJobEdit.js > index bcd2f2fb2..2b3660ed9 100644 > --- a/www/window/SyncJobEdit.js > +++ b/www/window/SyncJobEdit.js > @@ -177,7 +177,7 @@ Ext.define('PBS.window.SyncJobEdit', { > fieldLabel: gettext('Sync Schedule'), > xtype: 'pbsCalendarEvent', > name: 'schedule', > - emptyText: gettext('none (disabled)'), > + emptyText: gettext('none'), > cbind: { > deleteEmpty: '{!isCreate}', > value: '{scheduleValue}', > @@ -191,6 +191,27 @@ Ext.define('PBS.window.SyncJobEdit', { > submitAutoScaledSizeUnit: true, > // NOTE: handle deleteEmpty in onGetValues due to bandwidth field having a cbind too > }, > + { > + fieldLabel: gettext('Run when mounted'), > + xtype: 'proxmoxcheckbox', > + name: 'run-on-mount', > + autoEl: { > + tag: 'div', > + 'data-qtip': gettext('Run this job when a relevant removable datastore is mounted'), > + }, > + uncheckedValue: false, > + value: false, > + listeners: { > + change: function(checkbox, runOnMount) { > + let me = this; > + let form = me.up('pbsSyncJobEdit'); > + let scheduleField = form.down('field[name=schedule]'); > + if (runOnMount) { > + scheduleField.clearValue(); clearing the schedule field's value is not enough. Clicking the checkbox should also disable that field, as otherwise one can re-add a schedule after setting the flag. Further, if this is a requirement, setting and getting the sync job config should also include a check for that? Although I'm not sure it is really required for a sync job which runs on mount to not be also be able to run on schedule? > + } > + }, > + }, > + }, > ], > > column2: [ _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel