public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>,
	pbs-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox-backup 1/2] fix #6373: HTTP level reader heartbeat for proxy connection keepalive
Date: Wed, 15 Apr 2026 13:22:08 +0200	[thread overview]
Message-ID: <bdb393a0-7a9b-47f0-a43c-69cc6dc5171a@proxmox.com> (raw)
In-Reply-To: <1776250781.4vefy5jjsj.astroid@yuna.none>

On 4/15/26 12:59 PM, Fabian Grünbichler wrote:
> On April 15, 2026 10:45 am, Christian Ebner wrote:
>> On 4/15/26 10:32 AM, Fabian Grünbichler wrote:
>>> On January 29, 2026 1:26 pm, Christian Ebner wrote:
>>>> Backup readers can have long periods of idle connections, e.g. if a
>>>> backup snapshot has been mounted and all relevant chunks are locally
>>>> cached or a backup session with previous metadata archive not needing
>>>> to fetch new contents while the backup is ongoing.
>>>>
>>>> Proxies like e.g. HAProxy might however close idle connections for
>>>> better resource handling [0,1], even multiplexed HTTP/2 connections as
>>>> are being used for the Proxmox Backup Sever backup/reader protocol.
>>>>
>>>> This mainly affects the backup reader, while the backup writer will
>>>> do indexing and chunk uploads anyways.
>>>
>>> but if the storage is slow, there might not be chunk traffic for a few
>>> seconds as well?
>> So you suggest to implement the same for the backup writer as well?
> 
> I am wondering whether it wouldn't make sense (though I guess 5s is
> quite agressive anyway, and higher idle timeouts make it unlikely to
> trigger in practice?)


Yes, I think for the writer this is way less relevant.
Only the super slow storage case where the chunk is uploaded quickly, 
but then the storage takes ages to write it.

OTOH the heartbeat does not interfere much with the current request 
logic, and is guarded behind the environment variable.

So this would be enabled under very specific conditions anyways? After 
all it is mostly only a way out if one has no control over the proxy to 
increase the timeout values there?




  reply	other threads:[~2026-04-15 11:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-29 12:26 [RFC proxmox{,-backup} 0/3] fix #6373: HTTP level keepalive for http2 backup reader connection Christian Ebner
2026-01-29 12:26 ` [PATCH proxmox 1/1] rest-server: add request logfilter by method and path in h2 service Christian Ebner
2026-01-29 12:26 ` [PATCH proxmox-backup 1/2] fix #6373: HTTP level reader heartbeat for proxy connection keepalive Christian Ebner
2026-04-15  8:33   ` Fabian Grünbichler
2026-04-15  8:45     ` Christian Ebner
2026-04-15 11:00       ` Fabian Grünbichler
2026-04-15 11:22         ` Christian Ebner [this message]
2026-04-15 11:48           ` Fabian Grünbichler
2026-04-15 11:56             ` Christian Ebner
2026-01-29 12:27 ` [PATCH proxmox-backup 2/2] api: h2service: avoid logging heartbeat requests to task log Christian Ebner
2026-04-10 17:11 ` [RFC proxmox{,-backup} 0/3] fix #6373: HTTP level keepalive for http2 backup reader connection Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bdb393a0-7a9b-47f0-a43c-69cc6dc5171a@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=f.gruenbichler@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal