public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Gabriel Goller <g.goller@proxmox.com>
To: Christoph Heiss <c.heiss@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox v2 2/3] fix #6121: network-api: config: add support for `bond-miimon` option
Date: Mon, 9 Nov 2026 15:57:32 +0100	[thread overview]
Message-ID: <avHfKTTXUZXoiTv3@luna.proxmox.com> (raw)
In-Reply-To: <20261109143117.778971-3-c.heiss@proxmox.com>

On 09.11.2026 15:28, Christoph Heiss wrote:
> Fixes #6121 [0].
> 
> Adds support for the 'bond-miimon' option to the ifupdown(2) config
> writer and parser.
> 
> The option is always written out for bonds, with a default value of 100
> - much like PVE does it.

Umm I understand this but what about the bond-arp-interval (arp-mode). These
properties are mutually exclusive...

Maybe we should allow the user to configure arp mode as well?

> This is needed so that (at least) in active-backup mode, the bond
> correctly switches over to the backup link if the active one goes down.
> 
> [0] https://bugzilla.proxmox.com/show_bug.cgi?id=6121
> 
> Reviewed-by: Christian Ebner <c.ebner@proxmox.com>
> Tested-by: Christian Ebner <c.ebner@proxmox.com>
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
> Changes v1 -> v2:
>   * no changes
> 
>  proxmox-network-api/src/config/lexer.rs  |  3 +
>  proxmox-network-api/src/config/mod.rs    | 70 ++++++++++++++++++++++++
>  proxmox-network-api/src/config/parser.rs | 23 ++++++++
>  3 files changed, 96 insertions(+)
> 
> [snip]




  reply	other threads:[~2026-11-09 14:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-09 14:28 [PATCH proxmox{,-backup} v2 0/3] fix #6121: add 'bond-miimon' option for network interfaces Christoph Heiss
2026-11-09 14:28 ` [PATCH proxmox v2 1/3] fix #6121: network-api: api: add `bond-miimon` option for interfaces Christoph Heiss
2026-11-09 14:28 ` [PATCH proxmox v2 2/3] fix #6121: network-api: config: add support for `bond-miimon` option Christoph Heiss
2026-11-09 14:57   ` Gabriel Goller [this message]
2026-11-10 10:13     ` Christoph Heiss
2026-11-10 10:58       ` Gabriel Goller
2026-11-09 14:28 ` [PATCH proxmox-backup v2 3/3] api: network: reuse interface create/update methods from network-api Christoph Heiss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avHfKTTXUZXoiTv3@luna.proxmox.com \
    --to=g.goller@proxmox.com \
    --cc=c.heiss@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal