From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id A67DE1FF09B for ; Mon, 09 Nov 2026 15:57:38 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 14AB72140D; Mon, 09 Nov 2026 15:57:38 +0100 (CET) Date: Mon, 9 Nov 2026 15:57:32 +0100 From: Gabriel Goller To: Christoph Heiss Subject: Re: [PATCH proxmox v2 2/3] fix #6121: network-api: config: add support for `bond-miimon` option Message-ID: References: <20261109143117.778971-1-c.heiss@proxmox.com> <20261109143117.778971-3-c.heiss@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20261109143117.778971-3-c.heiss@proxmox.com> User-Agent: NeoMutt/20260504 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794236253182 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.235 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: MF22PNVOBQ7ZXAEC7LGI7UAUUHHDBXTK X-Message-ID-Hash: MF22PNVOBQ7ZXAEC7LGI7UAUUHHDBXTK X-MailFrom: g.goller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pbs-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 09.11.2026 15:28, Christoph Heiss wrote: > Fixes #6121 [0]. > > Adds support for the 'bond-miimon' option to the ifupdown(2) config > writer and parser. > > The option is always written out for bonds, with a default value of 100 > - much like PVE does it. Umm I understand this but what about the bond-arp-interval (arp-mode). These properties are mutually exclusive... Maybe we should allow the user to configure arp mode as well? > This is needed so that (at least) in active-backup mode, the bond > correctly switches over to the backup link if the active one goes down. > > [0] https://bugzilla.proxmox.com/show_bug.cgi?id=6121 > > Reviewed-by: Christian Ebner > Tested-by: Christian Ebner > Signed-off-by: Christoph Heiss > --- > Changes v1 -> v2: > * no changes > > proxmox-network-api/src/config/lexer.rs | 3 + > proxmox-network-api/src/config/mod.rs | 70 ++++++++++++++++++++++++ > proxmox-network-api/src/config/parser.rs | 23 ++++++++ > 3 files changed, 96 insertions(+) > > [snip]