From: Christian Ebner <c.ebner@proxmox.com>
To: Jakob Klocker <j.klocker@proxmox.com>, pbs-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox-backup v3 0/3] fix #6990: server: drop verify state on push & pull job
Date: Fri, 25 Sep 2026 12:20:23 +0200 [thread overview]
Message-ID: <a856588c-4fe8-4717-82b2-a1ce9bf31018@proxmox.com> (raw)
In-Reply-To: <20260922131110.313302-1-j.klocker@proxmox.com>
On 9/22/26 3:11 PM, Jakob Klocker wrote:
> When syncing a snapshot to another datastore, the source's verify_state
> is currently carried over to the target. This reports the target
> snapshot as verified even though its stored copy was never checked
> there. Since verify jobs skip snapshots that already carry a
> verify_state, the target's copy can't be verified again.
>
> Chunks are checksummed in memory while being transferred, but a verify
> serves a different purpose: confirming the write to the (external)
> target actually succeeded.
>
> This series stops the target from inheriting the source's
> verify_state, so the target is verified independently. On pull, a
> verify_state the target obtained on its own is preserved; on push the
> state is dropped unconditionally. It also moves the blocking calls in
> the touched code paths off the runtime's worker threads onto the
> blocking thread pool.
>
> Tested (verify_state correctly stripped on target):
> * Pull, verified source, new content, clean sync
> * Pull, verified source, existing content, clean sync
> * Pull, corrupted target, resync-corrupt
> * Push, verified source (has no corrupt path)
> * Pull, independently-verified target, clean re-sync - state preserved
Could not find any issues apart the mentioned comments and notes left on
individual patches.
With those addressed, consider:
Reviewed-by: Christian Ebner <c.ebner@proxmox.com>
Tested-by: Christian Ebner <c.ebner@proxmox.com>
prev parent reply other threads:[~2026-09-25 10:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 13:11 [PATCH proxmox-backup v3 0/3] fix #6990: server: drop verify state on push & pull job Jakob Klocker
2026-09-22 13:11 ` [PATCH proxmox-backup v3 1/3] server: pull: run blocking file operations on the blocking pool Jakob Klocker
2026-09-25 10:17 ` Christian Ebner
2026-09-22 13:11 ` [PATCH proxmox-backup v3 2/3] fix #6990: server: drop verify state on push job Jakob Klocker
2026-09-25 10:17 ` Christian Ebner
2026-09-22 13:11 ` [PATCH proxmox-backup v3 3/3] fix #6990: server: drop verify state on non-decrypt pull job Jakob Klocker
2026-09-25 10:17 ` Christian Ebner
2026-09-25 10:20 ` Christian Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a856588c-4fe8-4717-82b2-a1ce9bf31018@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=j.klocker@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox